From: Antonio Quartulli <antonio@meshcoding.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [PATCH 2/2] mac80211: store the channel in wdev upon ibss_join
Date: Thu, 17 Oct 2013 16:48:24 +0200 [thread overview]
Message-ID: <20131017144824.GH2596@neomailbox.net> (raw)
In-Reply-To: <1382020588.14410.12.camel@jlt4.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Thu, Oct 17, 2013 at 04:36:28PM +0200, Johannes Berg wrote:
> On Tue, 2013-10-15 at 00:38 +0200, Antonio Quartulli wrote:
> > From: Antonio Quartulli <antonio@open-mesh.com>
> >
> > To allow cfg80211 to use the real channel to pick up the
> > proper (i)bss object, store the used channel in
> > wdev->channel during ibss_join
>
> WTF? No, mac80211 can't just randomly modify cfg80211-owned data.
Mh, ok. :)
What about setting wdev->channel in __cfg80211_join_ibss() right after having
set wdev->ssid ?
This way we leave mac80211 out and we totally handle this thing in cfg80211
only.
(I think with this change patch 1/2 makes more sense?)
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-17 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 22:38 [PATCH 1/2] cfg80211: on ibss_joined use the channel to get the proper bss object Antonio Quartulli
2013-10-14 22:38 ` [PATCH 2/2] mac80211: store the channel in wdev upon ibss_join Antonio Quartulli
2013-10-17 14:36 ` Johannes Berg
2013-10-17 14:48 ` Antonio Quartulli [this message]
2013-10-17 14:51 ` Johannes Berg
2013-10-17 14:57 ` Antonio Quartulli
2013-10-17 14:35 ` [PATCH 1/2] cfg80211: on ibss_joined use the channel to get the proper bss object Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017144824.GH2596@neomailbox.net \
--to=antonio@meshcoding.com \
--cc=antonio@open-mesh.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox