* [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c
@ 2013-10-26 19:20 Georgiana Rodica Chelu
2013-10-28 21:30 ` [OPW kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Georgiana Rodica Chelu @ 2013-10-26 19:20 UTC (permalink / raw)
To: opw-kernel; +Cc: linux-wireless
WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
to printk(KERN_WARNING ...
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
drivers/net/wireless/adm8211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index f9a24e5..e36d54d 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
else
priv->rf_type = ADM8211_TYPE_AIROHA;
- printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
+ pr_warn("%s (adm8211): Unknown RFtype %d\n",
pci_name(priv->pdev), (cr49 >> 3) & 0x7);
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [OPW kernel] [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c
2013-10-26 19:20 [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c Georgiana Rodica Chelu
@ 2013-10-28 21:30 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-10-28 21:30 UTC (permalink / raw)
To: Georgiana Rodica Chelu; +Cc: opw-kernel, linux-wireless
On Sat, Oct 26, 2013 at 10:20:53PM +0300, Georgiana Rodica Chelu wrote:
> WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(...
> to printk(KERN_WARNING ...
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
> ---
> drivers/net/wireless/adm8211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Like Sarah said, we can't take these as they are not against the staging
tree.
And even if they were:
> diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> index f9a24e5..e36d54d 100644
> --- a/drivers/net/wireless/adm8211.c
> +++ b/drivers/net/wireless/adm8211.c
> @@ -151,7 +151,7 @@ static int adm8211_read_eeprom(struct ieee80211_hw *dev)
> else
> priv->rf_type = ADM8211_TYPE_AIROHA;
>
> - printk(KERN_WARNING "%s (adm8211): Unknown RFtype %d\n",
> + pr_warn("%s (adm8211): Unknown RFtype %d\n",
You didn't read the message that sparse was telling you, why didn't you
convert this to netdev_warn() instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-28 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-26 19:20 [Patch v3 1/3] net: wireless: replace printk with pr_warn in adm8211.c Georgiana Rodica Chelu
2013-10-28 21:30 ` [OPW kernel] " Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).