Re: [PATCH] staging: vt6656: device.h Remove typedef enum __device_init_type.

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Oct 22, 2013 at 08:26:14PM +0100, Malcolm Priestley wrote:
> Since typedef enum __device_init_type is only ever called
> in one state.

Then why not remove it entirely?

> Remove the typedef from main_usb.c:device_init_registers
> and if braces and just apply the enum value to sInitCmd.byInitClass.

You kind of did this, but things are still a bit messed up:

>      }
> -    if (InitType == DEVICE_INIT_COLD) {
>  
>          ntStatus = CONTROLnsRequestIn(pDevice,MESSAGE_TYPE_INIT_RSP,0,0,sizeof(RSP_CARD_INIT), (u8 *) &(sInitRsp));
>  
> @@ -574,7 +572,6 @@ static int device_init_registers(struct vnt_private *pDevice,
>  	/* if exist SW network address, use it */
>  	DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"Network address = %pM\n",
>  		pDevice->abyCurrentNetAddr);
> -    }

You remove this if, but the indentation is not fixed up.

Just remove the enum entirely if it's not used.

thanks,

greg k-h