From: Dan Carpenter <dan.carpenter@oracle.com>
To: emmanuel.grumbach@intel.com
Cc: linux-wireless@vger.kernel.org
Subject: re: iwlwifi: mvm: BT Coex - don't limit agg size in loose scheme
Date: Fri, 1 Nov 2013 13:28:48 +0300 [thread overview]
Message-ID: <20131101102848.GI29795@longonot.mountain> (raw)
Hello Emmanuel Grumbach,
This is a semi-automatic email about new static checker warnings.
The patch 9145d15128bd: "iwlwifi: mvm: BT Coex - don't limit agg size
in loose scheme" from Jul 18, 2013, leads to the following Smatch
complaint:
drivers/net/wireless/iwlwifi/mvm/rs.c:2491 rs_fill_link_cmd()
error: we previously assumed 'mvm' could be null (see line 2412)
drivers/net/wireless/iwlwifi/mvm/rs.c
2411 repeat_rate--;
2412 if (mvm)
^^^
Existing check.
2413 valid_tx_ant = iwl_fw_valid_tx_ant(mvm->fw);
2414
2415 /* Fill rest of rate table */
2416 while (index < LINK_QUAL_MAX_RETRY_NUM) {
2417 /* Repeat initial/next rate.
2418 * For legacy IWL_NUMBER_TRY == 1, this loop will not execute.
2419 * For HT IWL_HT_NUMBER_TRY == 3, this executes twice. */
[snip]
2481 }
2482
2483 lq_cmd->agg_frame_cnt_limit = LINK_QUAL_AGG_FRAME_LIMIT_DEF;
2484 lq_cmd->agg_disable_start_th = LINK_QUAL_AGG_DISABLE_START_DEF;
2485
2486 lq_cmd->agg_time_limit =
2487 cpu_to_le16(LINK_QUAL_AGG_TIME_LIMIT_DEF);
2488
2489 if (sta)
2490 lq_cmd->agg_time_limit =
2491 cpu_to_le16(iwl_mvm_bt_coex_agg_time_limit(mvm, sta));
^^^
Patch introduces new unchecked dereference.
2492 }
2493
regards,
dan carpenter
next reply other threads:[~2013-11-01 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 10:28 Dan Carpenter [this message]
2013-11-02 19:41 ` iwlwifi: mvm: BT Coex - don't limit agg size in loose scheme Grumbach, Emmanuel
2013-11-05 8:30 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101102848.GI29795@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox