From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:18597 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802Ab3KFGu5 (ORCPT ); Wed, 6 Nov 2013 01:50:57 -0500 Date: Wed, 6 Nov 2013 09:50:30 +0300 From: Dan Carpenter To: Sujith Manoharan Cc: "John W. Linville" , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net, kernel-janitors@vger.kernel.org Subject: Re: [patch] ath9k: fix SC_OP_INVALID test in ath9k_tx99_init() Message-ID: <20131106065030.GR26669@mwanda> (sfid-20131106_075101_315650_60930FFA) References: <20131105202034.GC3949@elgon.mountain> <21113.53593.471557.385898@gargle.gargle.HOWL> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <21113.53593.471557.385898@gargle.gargle.HOWL> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Nov 06, 2013 at 10:49:21AM +0530, Sujith Manoharan wrote: > Dan Carpenter wrote: > > SC_OP_INVALID is zero so the test is always false. We're supposed to be > > testing the lowest bit instead. > > > > Fixes: 89f927af7f33 ('ath9k: add TX99 support') > > Signed-off-by: Dan Carpenter > > > > diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c > > index 74f452c..7ad4e11 100644 > > --- a/drivers/net/wireless/ath/ath9k/main.c > > +++ b/drivers/net/wireless/ath/ath9k/main.c > > @@ -2456,7 +2456,7 @@ int ath9k_tx99_init(struct ath_softc *sc) > > struct ath_tx_control txctl; > > int r; > > > > - if (sc->sc_flags & SC_OP_INVALID) { > > + if (test_bit(SC_OP_INVALID, &sc->sc_flags)) { > > ath_err(common, > > "driver is in invalid state unable to use TX99"); > > return -EINVAL; > > Nice catch. > > The tx99 code in ath9k has been moved to a separate file, is it okay if I adopt > this patch and update it ? > Yeah. That's fine. regards, dan carpenter