From: Dan Carpenter <dan.carpenter@oracle.com>
To: Max.Stepanov@intel.com
Cc: Johannes Berg <johannes.berg@intel.com>, linux-wireless@vger.kernel.org
Subject: re: iwlwifi: mvm: add a generic cipher scheme support
Date: Thu, 19 Dec 2013 20:05:41 +0300 [thread overview]
Message-ID: <20131219170541.GA21029@elgon.mountain> (raw)
Hello Max Stepanov,
The patch e36e5433c98d: "iwlwifi: mvm: add a generic cipher scheme
support" from Aug 27, 2013, leads to the following (soon to be pushed)
Smatch warning:
drivers/net/wireless/iwlwifi/mvm/mac80211.c:265 iwl_mvm_mac_setup_register()
warn: this array is probably non-NULL. 'mvm->fw->cs'
drivers/net/wireless/iwlwifi/mvm/mac80211.c
264 /* currently FW API supports only one optional cipher scheme */
265 if (mvm->fw->cs && mvm->fw->cs->cipher) {
^^^^^^^^^^^
This is an array, not a pointer.
266 mvm->hw->n_cipher_schemes = 1;
267 mvm->hw->cipher_schemes = mvm->fw->cs;
268 }
regards,
dan carpenter
next reply other threads:[~2013-12-19 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 17:05 Dan Carpenter [this message]
2014-01-01 11:31 ` iwlwifi: mvm: add a generic cipher scheme support Stepanov, Max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219170541.GA21029@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=Max.Stepanov@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).