* re: iwlwifi: mvm: add a generic cipher scheme support
@ 2013-12-19 17:05 Dan Carpenter
2014-01-01 11:31 ` Stepanov, Max
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-12-19 17:05 UTC (permalink / raw)
To: Max.Stepanov; +Cc: Johannes Berg, linux-wireless
Hello Max Stepanov,
The patch e36e5433c98d: "iwlwifi: mvm: add a generic cipher scheme
support" from Aug 27, 2013, leads to the following (soon to be pushed)
Smatch warning:
drivers/net/wireless/iwlwifi/mvm/mac80211.c:265 iwl_mvm_mac_setup_register()
warn: this array is probably non-NULL. 'mvm->fw->cs'
drivers/net/wireless/iwlwifi/mvm/mac80211.c
264 /* currently FW API supports only one optional cipher scheme */
265 if (mvm->fw->cs && mvm->fw->cs->cipher) {
^^^^^^^^^^^
This is an array, not a pointer.
266 mvm->hw->n_cipher_schemes = 1;
267 mvm->hw->cipher_schemes = mvm->fw->cs;
268 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: iwlwifi: mvm: add a generic cipher scheme support
2013-12-19 17:05 iwlwifi: mvm: add a generic cipher scheme support Dan Carpenter
@ 2014-01-01 11:31 ` Stepanov, Max
0 siblings, 0 replies; 2+ messages in thread
From: Stepanov, Max @ 2014-01-01 11:31 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Berg, Johannes, linux-wireless@vger.kernel.org
>drivers/net/wireless/iwlwifi/mvm/mac80211.c
> 264 /* currently FW API supports only one optional cipher scheme */
> 265 if (mvm->fw->cs && mvm->fw->cs->cipher) {
> ^^^^^^^^^^^
>This is an array, not a pointer.
1. Apologies for delay of my reply, I'm back to the office from vacation today.
2. I see that Emmanuel already sent the fix yesterday. See [PATCH 18/28] iwlwifi: mvm: fix harmless smatch / coccinelle warnings
Regards,
Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-01 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-19 17:05 iwlwifi: mvm: add a generic cipher scheme support Dan Carpenter
2014-01-01 11:31 ` Stepanov, Max
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).