From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: vt6656: sparse fixes: aes_ccmp.c missing header.
Date: Mon, 13 Jan 2014 15:46:14 -0800 [thread overview]
Message-ID: <20140113234614.GA16467@kroah.com> (raw)
In-Reply-To: <1389630555.2590.6.camel@canaries32-MCP7A>
On Mon, Jan 13, 2014 at 04:29:15PM +0000, Malcolm Priestley wrote:
> Add missing aes_ccmp.h header and move device.h to
> aes_ccmp.h
Why move device.h?
That shouldn't be needed to fix this issue.
> sparse warning
> aes_ccmp.c:221:6: warning: symbol 'AESbGenCCMP' was not declared. Should it be static?
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> ---
> drivers/staging/vt6656/aes_ccmp.c | 2 +-
> drivers/staging/vt6656/aes_ccmp.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/aes_ccmp.c b/drivers/staging/vt6656/aes_ccmp.c
> index 61b9f7b..3dbf458 100644
> --- a/drivers/staging/vt6656/aes_ccmp.c
> +++ b/drivers/staging/vt6656/aes_ccmp.c
> @@ -30,7 +30,7 @@
> * Revision History:
> */
>
> -#include "device.h"
> +#include "aes_ccmp.h"
> #include "80211hdr.h"
>
> /*
> diff --git a/drivers/staging/vt6656/aes_ccmp.h b/drivers/staging/vt6656/aes_ccmp.h
> index ed6a9ae..4cac3ec 100644
> --- a/drivers/staging/vt6656/aes_ccmp.h
> +++ b/drivers/staging/vt6656/aes_ccmp.h
> @@ -30,6 +30,8 @@
> #ifndef __AES_H__
> #define __AES_H__
>
> +#include "device.h"
If you can prevent it, keeping .h files from having to include other .h
files is a good thing.
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-13 23:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 16:29 [PATCH 6/6] staging: vt6656: sparse fixes: aes_ccmp.c missing header Malcolm Priestley
2014-01-13 23:46 ` Greg KH [this message]
2014-01-14 21:00 ` Malcolm Priestley
2014-01-14 21:19 ` Greg KH
2014-01-15 19:55 ` Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113234614.GA16467@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).