From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: vt6656: sparse fixes: aes_ccmp.c missing header.
Date: Tue, 14 Jan 2014 13:19:29 -0800 [thread overview]
Message-ID: <20140114211929.GD28705@kroah.com> (raw)
In-Reply-To: <1389733208.8159.9.camel@canaries32-MCP7A>
On Tue, Jan 14, 2014 at 09:00:08PM +0000, Malcolm Priestley wrote:
> On Mon, 2014-01-13 at 15:46 -0800, Greg KH wrote:
> > On Mon, Jan 13, 2014 at 04:29:15PM +0000, Malcolm Priestley wrote:
> > > Add missing aes_ccmp.h header and move device.h to
> > > aes_ccmp.h
> >
> > Why move device.h?
> device.h is needed by aes_ccmp.h and only currently gets away with it
> by the include order elsewhere.
Then fix that up first.
> I didn't see the need to include device.h twice or fix
> it with the include order in aes_ccmo.c, there is enough of
> that already in this driver.
Fix it properly, as it will have to be resolved sometime, right?
thanks,
greg k-h
next prev parent reply other threads:[~2014-01-14 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 16:29 [PATCH 6/6] staging: vt6656: sparse fixes: aes_ccmp.c missing header Malcolm Priestley
2014-01-13 23:46 ` Greg KH
2014-01-14 21:00 ` Malcolm Priestley
2014-01-14 21:19 ` Greg KH [this message]
2014-01-15 19:55 ` Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114211929.GD28705@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).