Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/3] cfg80211: introduce regulatory wide bandwidth flag
Date: Fri, 24 Jan 2014 16:32:57 -0800	[thread overview]
Message-ID: <20140125003255.GE28512@garbanzo.do-not-panic.com> (raw)
In-Reply-To: <1390492620.4142.33.camel@jlt4.sipsolutions.net>

On Thu, Jan 23, 2014 at 04:57:00PM +0100, Johannes Berg wrote:
> On Wed, 2014-01-22 at 13:43 +0100, Janusz Dziedzic wrote:
> > Introduce regulatory flags field, NL80211_REG_WIDE_BW
> > country flag and new attribute NL80211_ATTR_REG_FLAGS.
> > If NL80211_REG_WIDE_BW is set, check rules and calculate
> > maximum bandwidth base on all contiguous regulatory rules.
> > If unset get maximum badwitdh from regulatory rule.
> > This patch is backward compatible with current CRDA/db.txt
> > implementation.
> 
> This seems reasonable, thanks. Maybe we should require the bandwidth to
> not be set at all or something? At least maybe in the regdb parser - it
> makes very little sense to have @20 and then ignore it completely?
> 
> Or maybe the userspace code could just not expose the flag, but rather
> set the new "wide_bw" flag when all the rules are marked as @N/A (and
> treat a combination of @number and @N/A as a bug)?

The optimizer code I added to CRDA does all this for us, so technically,
unless I'm missing something, this could be dealt with magically in
userspace. Its also unclear why we'd define this as a regulatory
parameter -- this just seems to make sense.

I'd look at extending CRDA binary to use the optimizer on the regulatory
domain prior to sending it to the kernel. All of a sudden you get full
support for this for free on any kernel.

  Luis

  reply	other threads:[~2014-01-25  0:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 12:43 [PATCH v2 1/3] cfg80211: add helper reg_get_regdomain() function Janusz Dziedzic
2014-01-22 12:43 ` [PATCH v2 2/3] cfg80211: introduce regulatory wide bandwidth flag Janusz Dziedzic
2014-01-23 15:57   ` Johannes Berg
2014-01-25  0:32     ` Luis R. Rodriguez [this message]
2014-01-25  0:36       ` Luis R. Rodriguez
2014-01-25 10:29         ` Janusz Dziedzic
2014-01-29 13:10       ` Johannes Berg
2014-01-30  0:41         ` Luis R. Rodriguez
2014-01-31 13:42           ` Johannes Berg
2014-01-22 12:43 ` [PATCH v2 3/3] cfg80211: parse WIDE-BW flag for internal regdb option Janusz Dziedzic
2014-01-25  0:34 ` [PATCH v2 1/3] cfg80211: add helper reg_get_regdomain() function Luis R. Rodriguez
2014-01-28 19:23   ` Janusz Dziedzic
2014-01-28 19:42     ` Luis R. Rodriguez
2014-01-29  8:17       ` Johannes Berg
2014-01-29  9:44         ` Luis R. Rodriguez
2014-01-29  9:46           ` Luis R. Rodriguez
2014-01-29  9:58             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140125003255.GE28512@garbanzo.do-not-panic.com \
    --to=mcgrof@do-not-panic.com \
    --cc=janusz.dziedzic@tieto.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox