From: Simon Wunderlich <sw@simonwunderlich.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sujith Manoharan <sujith@msujith.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix IBSS join
Date: Thu, 30 Jan 2014 11:58:18 +0100 [thread overview]
Message-ID: <201401301158.18604.sw@simonwunderlich.de> (raw)
In-Reply-To: <1391069448.4134.0.camel@jlt4.sipsolutions.net>
> On Thu, 2014-01-30 at 13:05 +0530, Sujith Manoharan wrote:
> > Simon Wunderlich wrote:
> > > In the CSA case the BSS is still used, we modify the BSS entry in
> > > ieee80211_ibss_finish_csa() (which is not really clean, but done by
> > > all the current CSA code).
> > >
> > > Since the BSS is changed and the node continues to beacon, I think
> > > that's ok to do it like Sujith proposed.
> >
> > I think Johannes is right. If a station receives a CSA and is unable to
> > switch to the new channel, it leaves the IBSS network. In this case we
> > don't need to keep the BSS entry around, since we proceed to scan again.
>
> Hah, I wasn't paying attention ... yeah I think you're right, it's the
> *failure* case, in which we shouldn't care any more. Simon, you were
> thinking of the successful case, but that doesn't call disconnect ...
Oh yes, I was just thinking, not reading. You are right, of course! Thanks for
correcting me. :)
I see Sujith has already posted v2, thanks a lot!
Simon
prev parent reply other threads:[~2014-01-30 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 1:54 [PATCH] mac80211: Fix IBSS join Sujith Manoharan
2014-01-28 14:42 ` Simon Wunderlich
2014-01-29 12:08 ` Johannes Berg
2014-01-29 12:19 ` Simon Wunderlich
2014-01-30 7:35 ` Sujith Manoharan
2014-01-30 8:10 ` Johannes Berg
2014-01-30 10:58 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401301158.18604.sw@simonwunderlich.de \
--to=sw@simonwunderlich.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).