From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-oa0-f50.google.com ([209.85.219.50]:45623 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbaBKSAB (ORCPT ); Tue, 11 Feb 2014 13:00:01 -0500 Date: Tue, 11 Feb 2014 11:59:32 -0600 From: Calvin Owens To: Antonio Quartulli Cc: Joe Perches , Johannes Berg , "David S. Miller" , "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ieee80211: Print human-readable disassoc/deauth reason codes Message-ID: <20140211175932.GB782@gmail.com> (sfid-20140211_190034_945274_759D0295) References: <1391651088-31785-1-git-send-email-jcalvinowens@gmail.com> <1391661863.30094.56.camel@joe-AO722> <1392030546.4128.11.camel@jlt4.sipsolutions.net> <1392050359.2507.10.camel@joe-AO722> <20140211012523.GA2739@gmail.com> <1392082740.2507.49.camel@joe-AO722> <20140211163738.GA32043@gmail.com> <52FA546B.1060008@meshcoding.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <52FA546B.1060008@meshcoding.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tuesday 02/11 at 17:48 +0100, Antonio Quartulli wrote: > On 11/02/14 17:37, Calvin Owens wrote: > > Create a function to return a descriptive string for each reason code, > > and print that in addition to the numeric value in the kernel log. These > > codes are easily found on popular search engines, but one is generally > > not able to access the internet when dealing with wireless connectivity > > issues. > > > > Changes in v2: Refactored array of strings into switch statement. > > Changes in v3: Fix style problem, use simplifying macro for switch > > statement, eliminate temporary enum variable. > > > > Signed-off-by: Calvin Owens > > --- > > include/net/mac80211.h | 10 +++++++++ > > net/mac80211/main.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > net/mac80211/mlme.c | 12 +++++------ > > 3 files changed, 73 insertions(+), 6 deletions(-) > > > > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > > index f4ab2fb..d18acfe 100644 > > --- a/include/net/mac80211.h > > +++ b/include/net/mac80211.h > > @@ -2971,6 +2971,16 @@ struct ieee80211_ops { > > */ > > struct ieee80211_hw *ieee80211_alloc_hw(size_t priv_data_len, > > const struct ieee80211_ops *ops); > > +/** > > + * ieee80211_get_reason_code_string - Get human readable reason code > > + * > > + * This function returns a string describing the @reason_code. > > + * > > + * @reason_code: Reason code > > Kerneldoc is not properly formatted here. > The "@argument:" clause should be on the line right after the function > name (as explained in Documentation/kernel-doc-nano-HOWTO.txt), e.g.: > > /** > * function_name - blabla > * @arg: I am a good arg description > * I actually just copied the comment format above the functions surrounding the one I added, several of which also appear to be incorrectly formatted. I can submit a patch to fix those as well if you like: is it worth the trouble? Thanks, Calvin > Cheers, > > -- > Antonio Quartulli >