From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] iwlwifi: refactor the TX / RX ampdu override
Date: Wed, 12 Feb 2014 13:13:16 +0100 [thread overview]
Message-ID: <20140212121314.GE1315@redhat.com> (raw)
In-Reply-To: <1392203989-15645-1-git-send-email-emmanuel.grumbach@intel.com>
On Wed, Feb 12, 2014 at 01:19:49PM +0200, Emmanuel Grumbach wrote:
> Note that this modifies the module parameter values / string
> which means that distro will need to update their *.conf file
> (if any).
Hmm, this is not something that I would like to do ...
> -#define IWL_DISABLE_HT_ALL BIT(0)
> -#define IWL_DISABLE_HT_TXAGG BIT(1)
> -#define IWL_DISABLE_HT_RXAGG BIT(2)
> -#define IWL_DISABLE_HT_ALL BIT(1)
> +#define IWL_DISABLE_HT_TXAGG BIT(1)
> +#define IWL_DISABLE_HT_RXAGG BIT(1)
> +#define IWL_ENABLE_HT_TXAGG BIT(2)
> +#define IWL_ENABLE_HT_RXAGG BIT(3)
I think we can keep IWL_DISABLE_HT_ALL option. I should be possible to
make some per-device type default settings and if disable_11n == 0 use
them. Otherwise use settings from module parameter. Will that work ?
Stanislaw
next prev parent reply other threads:[~2014-02-12 12:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 8:51 pull request: iwlwifi 2013-02-12 Emmanuel Grumbach
2014-02-12 8:54 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 9:10 ` Stanislaw Gruszka
2014-02-12 9:21 ` Stanislaw Gruszka
2014-02-12 9:35 ` Grumbach, Emmanuel
2014-02-12 9:43 ` Sujith Manoharan
2014-02-12 9:45 ` Grumbach, Emmanuel
2014-02-12 9:53 ` Sujith Manoharan
2014-02-12 10:41 ` Stanislaw Gruszka
2014-02-12 9:08 ` pull request: iwlwifi 2014-02-12 (FIXED) Emmanuel Grumbach
2014-02-12 9:09 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 11:19 ` [RFC] iwlwifi: refactor the TX / RX ampdu override Emmanuel Grumbach
2014-02-12 12:13 ` Stanislaw Gruszka [this message]
2014-02-12 12:27 ` Grumbach, Emmanuel
2014-02-12 14:04 ` Stanislaw Gruszka
2014-02-12 20:28 ` Emmanuel Grumbach
2014-02-13 7:54 ` Stanislaw Gruszka
2014-02-13 12:28 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 11:02 ` pull request: iwlwifi 2014-02-12 (FIXED) Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212121314.GE1315@redhat.com \
--to=sgruszka@redhat.com \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).