From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Intel Linux Wireless (ilw@linux.intel.com)"
<ilw@linux.intel.com>
Subject: Re: [RFC] iwlwifi: refactor the TX / RX ampdu override
Date: Thu, 13 Feb 2014 08:54:27 +0100 [thread overview]
Message-ID: <20140213075427.GA1774@redhat.com> (raw)
In-Reply-To: <52FBD950.7080204@gmail.com>
On Wed, Feb 12, 2014 at 10:28:00PM +0200, Emmanuel Grumbach wrote:
> On 02/12/2014 04:04 PM, Stanislaw Gruszka wrote:
> > On Wed, Feb 12, 2014 at 12:27:05PM +0000, Grumbach, Emmanuel wrote:
> >>> I think we can keep IWL_DISABLE_HT_ALL option. I should be possible to
> >>> make some per-device type default settings and if disable_11n == 0 use
> >>> them. Otherwise use settings from module parameter. Will that work ?
> >>
> >> I'd prefer to have the default based on the iwldvm vs. iwlmvm instead of adding yet another per-HW field. But yeah - it is possible.
> >
> > I re-think changing default settings do disable TX AGG and must tell
> > that this is very odd. I would prefer to stay defaults as they are now.
> > Users can disable TX aggregation using module option.
>
> I disagree. We have bugs there - it is pretty much obvious. I remember a
> tracing from 2.6.39 which was before the re-architecture I made in the
> driver with clear FW bugs. I don't remember what device though.
> This is why I want to disable this by default.
Sure, it's up to you. But anyway, disabling feature because it buggy,
after having it run for 5 years or so, it's odd :-)
Stanislaw
next prev parent reply other threads:[~2014-02-13 7:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 8:51 pull request: iwlwifi 2013-02-12 Emmanuel Grumbach
2014-02-12 8:54 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 9:10 ` Stanislaw Gruszka
2014-02-12 9:21 ` Stanislaw Gruszka
2014-02-12 9:35 ` Grumbach, Emmanuel
2014-02-12 9:43 ` Sujith Manoharan
2014-02-12 9:45 ` Grumbach, Emmanuel
2014-02-12 9:53 ` Sujith Manoharan
2014-02-12 10:41 ` Stanislaw Gruszka
2014-02-12 9:08 ` pull request: iwlwifi 2014-02-12 (FIXED) Emmanuel Grumbach
2014-02-12 9:09 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 11:19 ` [RFC] iwlwifi: refactor the TX / RX ampdu override Emmanuel Grumbach
2014-02-12 12:13 ` Stanislaw Gruszka
2014-02-12 12:27 ` Grumbach, Emmanuel
2014-02-12 14:04 ` Stanislaw Gruszka
2014-02-12 20:28 ` Emmanuel Grumbach
2014-02-13 7:54 ` Stanislaw Gruszka [this message]
2014-02-13 12:28 ` [PATCH] iwlwifi: disable TX AMPDU by default for iwldvm Emmanuel Grumbach
2014-02-12 11:02 ` pull request: iwlwifi 2014-02-12 (FIXED) Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213075427.GA1774@redhat.com \
--to=sgruszka@redhat.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).