From: "John W. Linville" <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs
Date: Fri, 14 Feb 2014 09:27:27 -0500 [thread overview]
Message-ID: <20140214142726.GL22203@tuxdriver.com> (raw)
In-Reply-To: <CACna6rzAC1Z91TGRffuTcqV-tLpGwE52hzAXOgMstn4mZnLTbg@mail.gmail.com>
On Fri, Feb 14, 2014 at 01:01:00PM +0100, Rafał Miłecki wrote:
> 2014-02-14 0:34 GMT+01:00 Hauke Mehrtens <hauke@hauke-m.de>:
> > On 02/13/2014 06:06 PM, Rafał Miłecki wrote:
> >> Broadcom boards have 32 GPIOs (not 16) and these higher ones are
> >> actually used on some devices (for buttons, reset of WiFi devices).
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >> ---
> >> Similar patch may be needed for ssb, however I didn't meet any ssb SoC
> >> with GPIOs 16-31 connected to anything.
> >> This is so trivial I hope it can go as a fix for 3.14. It allows support
> >> for some devices that use these higher GPIOs.
> >> ---
> >> drivers/bcma/driver_gpio.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> > Are you sure all the bcma SoC have 32 GPIO lines or is there no problem
> > when they do not? For at least some ssb based SoCs I know that they only
> > have 16 GPIO lines.
>
> Damn, I'm afraid you may be right. I didn't think about that.
>
> I was able to find references to GPIOs 16-31 on BCM5357 based boards only.
Sounds like I need to revert that patch.
Please never, _ever_, post a patch (no matter how trivial) for the
stable tree unless you are absolutely sure about it in the first place.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-02-14 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 17:06 [3.14 FIX][PATCH] bcma: gpio: register all 32 GPIOs Rafał Miłecki
2014-02-13 20:04 ` Rafał Miłecki
2014-02-13 23:23 ` John W. Linville
2014-02-13 23:34 ` Hauke Mehrtens
2014-02-14 12:01 ` Rafał Miłecki
2014-02-14 14:27 ` John W. Linville [this message]
2014-02-14 15:40 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214142726.GL22203@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).