From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Bernhard Schiffner <bernhard@schiffner-limbach.de>,
Huqiu Liu <liuhq11@mails.tsinghua.edu.cn>
Subject: Re: [PATCH 3/7] rtl818x: check for pci_map_single() success when initializing RX ring
Date: Tue, 18 Feb 2014 21:27:15 +0300 [thread overview]
Message-ID: <20140218182714.GO26776@mwanda> (raw)
In-Reply-To: <CAN8YU5N=_-9hVZc+6sW5xrwmybQ_aTLAMFODzyuGk0g97OV6Gg@mail.gmail.com>
I guess what I was going to suggest is that you are overthinking the
error handling. Your code tries very hard to allocate 32 buffers. But
I bet it's just a matter of allocating the buffers and if it doesn't
work then clean up and return an error. Probably it alocates 32 buffers
successfully or it doesn't allocate any, it's less likely that we will
allocate a partial number of buffers.
If this were in the receive path or something like that then maybe we
would worry about situations like that. Although even in that case
probably the right approach would be to drop everything and let the
protocol handle the error... Offtopic. What I mean is that this is in
the init path so everything will likely work except in manufactured
situations.
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-18 18:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 1:10 [PATCH 0/7] rtl818x: second bunch of fixes ported from rtl8187se merge process Andrea Merello
2014-02-18 1:10 ` [PATCH 1/7] rtl818x: Explicitly enable contetion window Andrea Merello
2014-02-18 1:10 ` [PATCH 2/7] rtl818x: pci_iomap() should pair with pci_iounmap() Andrea Merello
2014-02-18 1:10 ` [PATCH 3/7] rtl818x: check for pci_map_single() success when initializing RX ring Andrea Merello
2014-02-18 9:31 ` Dan Carpenter
2014-02-18 18:05 ` Andrea Merello
2014-02-18 18:27 ` Dan Carpenter [this message]
2014-02-18 19:06 ` Andrea Merello
2014-02-18 19:22 ` Dan Carpenter
2014-02-18 20:17 ` Andrea Merello
2014-02-18 20:36 ` Dan Carpenter
2014-02-18 22:10 ` Andrea Merello
2014-02-22 16:57 ` [PATCH 3/7 V2] " Andrea Merello
2014-02-18 1:10 ` [PATCH 4/7] rtl818x: make dev_alloc_skb() null pointer check to really work Andrea Merello
2014-02-18 1:10 ` [PATCH 5/7] rtl818x: add comments to explain few not obvious HW configs Andrea Merello
2014-02-18 1:10 ` [PATCH 6/7] rtl818x: Make sure the TX descriptor "valid" flag is written by last Andrea Merello
2014-02-18 1:10 ` [PATCH 7/7] rtl818x: make sure TX descriptor writes are done before kicking DMA Andrea Merello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218182714.GO26776@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andrea.merello@gmail.com \
--cc=bernhard@schiffner-limbach.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=liuhq11@mails.tsinghua.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).