From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] mac80211: fix calling ieee80211_free_txskb with NULL skb
Date: Wed, 19 Feb 2014 16:00:05 +0100 [thread overview]
Message-ID: <20140219150004.GG1851@redhat.com> (raw)
In-Reply-To: <1392821414.4733.24.camel@jlt4.sipsolutions.net>
On Wed, Feb 19, 2014 at 03:50:14PM +0100, Johannes Berg wrote:
> On Wed, 2014-02-19 at 15:48 +0100, Stanislaw Gruszka wrote:
>
> > Ok, I think I see this, it seems to be race condition in
> > ieee80211_sta_ps_deliver_wakeup().
> >
> > Perhaps it could be solved by modifying
> > ieee80211_add_pending_skbs_fn() to take list of queues as argument,
> > that function seems properly stop queues, add buffered frames to
> > pending queue, clear WLAN_STA_PS_STA and then wake up queues. Or
> > just stop using ieee80211_add_pending_skbs_fn() and do the same
> > sequence directly on ieee80211_sta_ps_deliver_wakeup() .
>
> That might work, but we were considering just locking the sta->lock
> around the whole "pending" thing inside deliver_wakeup() and in the "is
> station sleeping" part. Then you also need to re-check ("is it still
> sleeping?") inside the lock.
Looks good to me, feel free to post that.
Stanislaw
prev parent reply other threads:[~2014-02-19 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 12:28 [PATCH 1/2] mac80211: fix calling ieee80211_free_txskb with NULL skb Stanislaw Gruszka
2014-02-19 12:28 ` [PATCH 2/2] mac80211: protect skb_queue_len(&ps->bc_buf) by lock Stanislaw Gruszka
2014-02-19 13:14 ` Johannes Berg
2014-02-19 13:35 ` Stanislaw Gruszka
2014-02-19 14:51 ` Johannes Berg
2014-02-19 15:09 ` Stanislaw Gruszka
2014-02-19 16:36 ` Johannes Berg
2014-02-20 7:56 ` Stanislaw Gruszka
2014-02-20 7:59 ` Johannes Berg
2014-02-20 8:17 ` Stanislaw Gruszka
2014-02-19 12:33 ` [PATCH 1/2] mac80211: fix calling ieee80211_free_txskb with NULL skb Johannes Berg
2014-02-19 12:39 ` Grumbach, Emmanuel
2014-02-19 12:46 ` Grumbach, Emmanuel
2014-02-19 13:21 ` Stanislaw Gruszka
2014-02-19 14:48 ` Stanislaw Gruszka
2014-02-19 14:50 ` Johannes Berg
2014-02-19 15:00 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219150004.GG1851@redhat.com \
--to=sgruszka@redhat.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).