From: Samuel Ortiz <sameo@linux.intel.com>
To: "Mark A. Greer" <mgreer@animalcreek.com>
Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
Felipe Balbi <balbi@ti.com>, Erick Macias <emacias@ti.com>,
Thierry Escande <thierry.escande@linux.intel.com>,
linux-wireless@vger.kernel.org, linux-nfc@lists.01.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] NFC: trf7970a: Add ISO/IEC 15693 Support
Date: Fri, 21 Feb 2014 02:00:44 +0100 [thread overview]
Message-ID: <20140221010044.GT18868@zurbaran> (raw)
In-Reply-To: <1391206631-9862-3-git-send-email-mgreer@animalcreek.com>
Hi Mark,
Just one nitpick here:
> +static int trf7970a_is_iso15693_write_or_lock(u8 cmd)
> +{
> + int ret;
> +
> + switch (cmd) {
> + case ISO15693_CMD_WRITE_SINGLE_BLOCK:
> + case ISO15693_CMD_LOCK_BLOCK:
> + case ISO15693_CMD_WRITE_MULTIPLE_BLOCK:
> + case ISO15693_CMD_WRITE_AFI:
> + case ISO15693_CMD_LOCK_AFI:
> + case ISO15693_CMD_WRITE_DSFID:
> + case ISO15693_CMD_LOCK_DSFID:
> + ret = 1;
return 1;
and return 0 on the default case.
Simpler code and you don't need the ret variable.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2014-02-21 1:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 22:17 [PATCH 0/3] NFC: trf7970a: Add driver with NFC Type 2 and Type V Support Mark A. Greer
2014-01-31 22:17 ` [PATCH 1/3] NFC: trf7970a: Add driver with ISO/IEC 14443 Type 2 Tag Support Mark A. Greer
2014-02-21 0:50 ` Samuel Ortiz
2014-02-21 1:20 ` Felipe Balbi
2014-02-26 21:53 ` Mark A. Greer
2014-03-03 18:11 ` Mark A. Greer
2014-03-03 20:37 ` Samuel Ortiz
2014-03-05 0:19 ` Mark A. Greer
2014-03-05 12:36 ` Samuel Ortiz
2014-01-31 22:17 ` [PATCH 2/3] NFC: trf7970a: Add ISO/IEC 15693 Support Mark A. Greer
2014-02-21 1:00 ` Samuel Ortiz [this message]
2014-02-26 21:53 ` Mark A. Greer
2014-01-31 22:17 ` [PATCH 3/3] NFC: trf7970a: Add DTS Documentation Mark A. Greer
2014-02-21 1:04 ` Samuel Ortiz
2014-02-26 21:54 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221010044.GT18868@zurbaran \
--to=sameo@linux.intel.com \
--cc=aloisio.almeida@openbossa.org \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=emacias@ti.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=thierry.escande@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox