From: Dan Carpenter <dan.carpenter@oracle.com>
To: nbd@openwrt.org
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
kbuild@01.org
Subject: re: ath9k: reduce baseband hang detection false positive rate
Date: Sat, 1 Mar 2014 02:17:09 +0300 [thread overview]
Message-ID: <20140228231709.GC22115@elgon.mountain> (raw)
Hello Felix Fietkau,
The patch d31a36a6d87f: "ath9k: reduce baseband hang detection false
positive rate" from Feb 24, 2014, leads to the following static
checker warning:
drivers/net/wireless/ath/ath9k/hw.c:1563 ath9k_hw_check_alive()
info: ignoring unreachable code.
drivers/net/wireless/ath/ath9k/hw.c
1545 do {
1546 reg = REG_READ(ah, AR_OBS_BUS_1);
1547 if (reg != last_val)
1548 return true;
1549
1550 last_val = reg;
1551 if ((reg & 0x7E7FFFEF) == 0x00702400)
1552 continue;
1553
1554 switch (reg & 0x7E000B00) {
1555 case 0x1E000000:
1556 case 0x52000B00:
1557 case 0x18000B00:
1558 continue;
1559 default:
1560 return true;
1561 }
1562
1563 udelay(1);
^^^^^^^^^
We never hit this recently added delay.
1564 } while (count-- > 0);
regards,
dan carpenter
reply other threads:[~2014-02-28 23:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228231709.GC22115@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=kbuild@01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).