linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: ath9k: reduce baseband hang detection false positive rate
@ 2014-02-28 23:17 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-02-28 23:17 UTC (permalink / raw)
  To: nbd; +Cc: linux-wireless, ath9k-devel, kbuild

Hello Felix Fietkau,

The patch d31a36a6d87f: "ath9k: reduce baseband hang detection false
positive rate" from Feb 24, 2014, leads to the following static
checker warning:

	drivers/net/wireless/ath/ath9k/hw.c:1563 ath9k_hw_check_alive()
	info: ignoring unreachable code.

drivers/net/wireless/ath/ath9k/hw.c
  1545          do {
  1546                  reg = REG_READ(ah, AR_OBS_BUS_1);
  1547                  if (reg != last_val)
  1548                          return true;
  1549  
  1550                  last_val = reg;
  1551                  if ((reg & 0x7E7FFFEF) == 0x00702400)
  1552                          continue;
  1553  
  1554                  switch (reg & 0x7E000B00) {
  1555                  case 0x1E000000:
  1556                  case 0x52000B00:
  1557                  case 0x18000B00:
  1558                          continue;
  1559                  default:
  1560                          return true;
  1561                  }
  1562  
  1563                  udelay(1);
                        ^^^^^^^^^
We never hit this recently added delay.

  1564          } while (count-- > 0);

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-02-28 23:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 23:17 ath9k: reduce baseband hang detection false positive rate Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).