Re: [PATCH 1/3] NFC: trf7970a: Add driver with ISO/IEC 14443 Type 2 Tag Support

Mark A. Greer
2014-03-03T18:11:14Z

On Wed, Feb 26, 2014 at 02:53:09PM -0700, Mark A. Greer wrote:
> On Fri, Feb 21, 2014 at 01:50:59AM +0100, Samuel Ortiz wrote:
> > Hi Mark,
>
> Hi Samuel - thanks for the feedback.
>
> > Code looks quite nice, especially since this looks like a fairly complex
> > driver. And the initial coments are quite useful, I appreciate that.
> > I have a few comments/questions though:
> >
> >
> > > + * been received and there isn't an error). The delay is 3 ms since delays
> > > + * over 2 ms have been observed during testing.
> > Would you say this timeout depend on the SPI bus bandwidth ?
>
> It'll be one of the factors but the tag's response characteristics are
> a big factor too. I can bump it up a bit more if you prefer or do you
> want me to somehow calculate it from the SPI bitrate?

Ping.