From: "John W. Linville" <linville@tuxdriver.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
"pali.rohar@gmail.com" <pali.rohar@gmail.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wl1251: use skb_trim to make skb shorter
Date: Tue, 4 Mar 2014 13:33:48 -0500 [thread overview]
Message-ID: <20140304183348.GB7317@tuxdriver.com> (raw)
In-Reply-To: <20140304142658.GK8766@mudshark.cambridge.arm.com>
OK, I'll queue it as a fix...
On Tue, Mar 04, 2014 at 02:26:58PM +0000, Will Deacon wrote:
> Hi Jonn,
>
> On Sat, Mar 01, 2014 at 12:52:06PM +0000, Ivaylo Dimitrov wrote:
> > the current code is directly setting skb->len, which is not correct and
> > brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config
> >
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > ---
>
> Can you pick this patch up please? It addresses a regression introduced in
> the merge window (ARM started selecting HAVE_EFFICIENT_UNALIGNED_ACCESS).
>
> Cheers,
>
> Will
>
> > drivers/net/wireless/ti/wl1251/rx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c
> > index 123c4bb..cde0eaf 100644
> > --- a/drivers/net/wireless/ti/wl1251/rx.c
> > +++ b/drivers/net/wireless/ti/wl1251/rx.c
> > @@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
> > wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);
> >
> > /* The actual length doesn't include the target's alignment */
> > - skb->len = desc->length - PLCP_HEADER_LENGTH;
> > + skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);
> >
> > fc = (u16 *)skb->data;
> >
> > --
> > 1.7.9.5
> >
> >
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-03-04 18:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140225105756.GB22279@mudshark.cambridge.arm.com>
2014-03-01 12:52 ` [PATCH] wl1251: use skb_trim to make skb shorter Ivaylo Dimitrov
2014-03-04 14:26 ` Will Deacon
2014-03-04 18:33 ` John W. Linville [this message]
2014-03-05 10:06 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304183348.GB7317@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).