* [PATCH] wl1251: use skb_trim to make skb shorter
[not found] <20140225105756.GB22279@mudshark.cambridge.arm.com>
@ 2014-03-01 12:52 ` Ivaylo Dimitrov
2014-03-04 14:26 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: Ivaylo Dimitrov @ 2014-03-01 12:52 UTC (permalink / raw)
To: linville
Cc: will.deacon, pali.rohar, pavel, linux-wireless, linux-kernel,
Ivaylo Dimitrov
the current code is directly setting skb->len, which is not correct and
brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
drivers/net/wireless/ti/wl1251/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c
index 123c4bb..cde0eaf 100644
--- a/drivers/net/wireless/ti/wl1251/rx.c
+++ b/drivers/net/wireless/ti/wl1251/rx.c
@@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);
/* The actual length doesn't include the target's alignment */
- skb->len = desc->length - PLCP_HEADER_LENGTH;
+ skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);
fc = (u16 *)skb->data;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wl1251: use skb_trim to make skb shorter
2014-03-01 12:52 ` [PATCH] wl1251: use skb_trim to make skb shorter Ivaylo Dimitrov
@ 2014-03-04 14:26 ` Will Deacon
2014-03-04 18:33 ` John W. Linville
0 siblings, 1 reply; 4+ messages in thread
From: Will Deacon @ 2014-03-04 14:26 UTC (permalink / raw)
To: Ivaylo Dimitrov
Cc: linville@tuxdriver.com, pali.rohar@gmail.com, pavel@ucw.cz,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Jonn,
On Sat, Mar 01, 2014 at 12:52:06PM +0000, Ivaylo Dimitrov wrote:
> the current code is directly setting skb->len, which is not correct and
> brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
Can you pick this patch up please? It addresses a regression introduced in
the merge window (ARM started selecting HAVE_EFFICIENT_UNALIGNED_ACCESS).
Cheers,
Will
> drivers/net/wireless/ti/wl1251/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c
> index 123c4bb..cde0eaf 100644
> --- a/drivers/net/wireless/ti/wl1251/rx.c
> +++ b/drivers/net/wireless/ti/wl1251/rx.c
> @@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
> wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);
>
> /* The actual length doesn't include the target's alignment */
> - skb->len = desc->length - PLCP_HEADER_LENGTH;
> + skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);
>
> fc = (u16 *)skb->data;
>
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wl1251: use skb_trim to make skb shorter
2014-03-04 14:26 ` Will Deacon
@ 2014-03-04 18:33 ` John W. Linville
2014-03-05 10:06 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: John W. Linville @ 2014-03-04 18:33 UTC (permalink / raw)
To: Will Deacon
Cc: Ivaylo Dimitrov, pali.rohar@gmail.com, pavel@ucw.cz,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
OK, I'll queue it as a fix...
On Tue, Mar 04, 2014 at 02:26:58PM +0000, Will Deacon wrote:
> Hi Jonn,
>
> On Sat, Mar 01, 2014 at 12:52:06PM +0000, Ivaylo Dimitrov wrote:
> > the current code is directly setting skb->len, which is not correct and
> > brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config
> >
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > ---
>
> Can you pick this patch up please? It addresses a regression introduced in
> the merge window (ARM started selecting HAVE_EFFICIENT_UNALIGNED_ACCESS).
>
> Cheers,
>
> Will
>
> > drivers/net/wireless/ti/wl1251/rx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c
> > index 123c4bb..cde0eaf 100644
> > --- a/drivers/net/wireless/ti/wl1251/rx.c
> > +++ b/drivers/net/wireless/ti/wl1251/rx.c
> > @@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
> > wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);
> >
> > /* The actual length doesn't include the target's alignment */
> > - skb->len = desc->length - PLCP_HEADER_LENGTH;
> > + skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);
> >
> > fc = (u16 *)skb->data;
> >
> > --
> > 1.7.9.5
> >
> >
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wl1251: use skb_trim to make skb shorter
2014-03-04 18:33 ` John W. Linville
@ 2014-03-05 10:06 ` Will Deacon
0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2014-03-05 10:06 UTC (permalink / raw)
To: John W. Linville
Cc: Ivaylo Dimitrov, pali.rohar@gmail.com, pavel@ucw.cz,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Mar 04, 2014 at 06:33:48PM +0000, John W. Linville wrote:
> OK, I'll queue it as a fix...
Thanks, John.
Will
> On Tue, Mar 04, 2014 at 02:26:58PM +0000, Will Deacon wrote:
> > Hi Jonn,
> >
> > On Sat, Mar 01, 2014 at 12:52:06PM +0000, Ivaylo Dimitrov wrote:
> > > the current code is directly setting skb->len, which is not correct and
> > > brings problems with HAVE_EFFICIENT_UNALIGNED_ACCESS enabled in config
> > >
> > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > > ---
> >
> > Can you pick this patch up please? It addresses a regression introduced in
> > the merge window (ARM started selecting HAVE_EFFICIENT_UNALIGNED_ACCESS).
> >
> > Cheers,
> >
> > Will
> >
> > > drivers/net/wireless/ti/wl1251/rx.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/wireless/ti/wl1251/rx.c b/drivers/net/wireless/ti/wl1251/rx.c
> > > index 123c4bb..cde0eaf 100644
> > > --- a/drivers/net/wireless/ti/wl1251/rx.c
> > > +++ b/drivers/net/wireless/ti/wl1251/rx.c
> > > @@ -180,7 +180,7 @@ static void wl1251_rx_body(struct wl1251 *wl,
> > > wl1251_mem_read(wl, rx_packet_ring_addr, rx_buffer, length);
> > >
> > > /* The actual length doesn't include the target's alignment */
> > > - skb->len = desc->length - PLCP_HEADER_LENGTH;
> > > + skb_trim(skb, desc->length - PLCP_HEADER_LENGTH);
> > >
> > > fc = (u16 *)skb->data;
> > >
> > > --
> > > 1.7.9.5
> > >
> > >
> >
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-05 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140225105756.GB22279@mudshark.cambridge.arm.com>
2014-03-01 12:52 ` [PATCH] wl1251: use skb_trim to make skb shorter Ivaylo Dimitrov
2014-03-04 14:26 ` Will Deacon
2014-03-04 18:33 ` John W. Linville
2014-03-05 10:06 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).