* pull request: iwlwifi 2014-03-04
@ 2014-03-04 17:35 Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 1/2] iwlwifi: mvm: don't WARN when statistics are handled late Emmanuel Grumbach
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Emmanuel Grumbach @ 2014-03-04 17:35 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, ilw
[-- Attachment #1: Type: text/plain, Size: 997 bytes --]
Hi John,
One more fix and an update for device IDs.
There is a bugzilla reported for the fix which is mentioned in the commit message.
Please pull.
emmanuel
The following changes since commit 143582c6847cb285b361804c613127c25de60ca4:
iwlwifi: fix TX status for aggregated packets (2014-02-27 10:28:03 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git for-john
for you to fetch changes up to acfcd9ed588465e48efe5ceb67177096d51c95a9:
iwlwifi: fix and add 7265 series HW IDs (2014-03-04 19:30:06 +0200)
----------------------------------------------------------------
Emmanuel Grumbach (1):
iwlwifi: mvm: don't WARN when statistics are handled late
Oren Givon (1):
iwlwifi: fix and add 7265 series HW IDs
drivers/net/wireless/iwlwifi/mvm/bt-coex.c | 7 +++++--
drivers/net/wireless/iwlwifi/pcie/drv.c | 5 ++---
2 files changed, 7 insertions(+), 5 deletions(-)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] iwlwifi: mvm: don't WARN when statistics are handled late
2014-03-04 17:35 pull request: iwlwifi 2014-03-04 Emmanuel Grumbach
@ 2014-03-04 17:36 ` Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 2/2] iwlwifi: fix and add 7265 series HW IDs Emmanuel Grumbach
2014-03-04 18:34 ` pull request: iwlwifi 2014-03-04 John W. Linville
2 siblings, 0 replies; 4+ messages in thread
From: Emmanuel Grumbach @ 2014-03-04 17:36 UTC (permalink / raw)
To: linux-wireless; +Cc: Emmanuel Grumbach, stable
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Since the statistics handler is asynchrous, it can very well
be that we will handle the statistics (hence the RSSI
fluctuation) when we already disassociated.
Don't WARN on this case.
This solves: https://bugzilla.redhat.com/show_bug.cgi?id=1071998
Cc: <stable@vger.kernel.org> [3.10+]
Fixes: 2b76ef13086f ("iwlwifi: mvm: implement reduced Tx power")
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/iwlwifi/mvm/bt-coex.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/mvm/bt-coex.c b/drivers/net/wireless/iwlwifi/mvm/bt-coex.c
index 76cde6c..18a895a 100644
--- a/drivers/net/wireless/iwlwifi/mvm/bt-coex.c
+++ b/drivers/net/wireless/iwlwifi/mvm/bt-coex.c
@@ -872,8 +872,11 @@ void iwl_mvm_bt_rssi_event(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
lockdep_assert_held(&mvm->mutex);
- /* Rssi update while not associated ?! */
- if (WARN_ON_ONCE(mvmvif->ap_sta_id == IWL_MVM_STATION_COUNT))
+ /*
+ * Rssi update while not associated - can happen since the statistics
+ * are handled asynchronously
+ */
+ if (mvmvif->ap_sta_id == IWL_MVM_STATION_COUNT)
return;
/* No BT - reports should be disabled */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] iwlwifi: fix and add 7265 series HW IDs
2014-03-04 17:35 pull request: iwlwifi 2014-03-04 Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 1/2] iwlwifi: mvm: don't WARN when statistics are handled late Emmanuel Grumbach
@ 2014-03-04 17:36 ` Emmanuel Grumbach
2014-03-04 18:34 ` pull request: iwlwifi 2014-03-04 John W. Linville
2 siblings, 0 replies; 4+ messages in thread
From: Emmanuel Grumbach @ 2014-03-04 17:36 UTC (permalink / raw)
To: linux-wireless; +Cc: Oren Givon, Emmanuel Grumbach
From: Oren Givon <oren.givon@intel.com>
Update of the HW IDs for the 7265 series.
Signed-off-by: Oren Givon <oren.givon@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
drivers/net/wireless/iwlwifi/pcie/drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/pcie/drv.c b/drivers/net/wireless/iwlwifi/pcie/drv.c
index f47bcbe..3872ead 100644
--- a/drivers/net/wireless/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/iwlwifi/pcie/drv.c
@@ -359,13 +359,12 @@ static DEFINE_PCI_DEVICE_TABLE(iwl_hw_card_ids) = {
/* 7265 Series */
{IWL_PCI_DEVICE(0x095A, 0x5010, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095A, 0x5110, iwl7265_2ac_cfg)},
- {IWL_PCI_DEVICE(0x095A, 0x5112, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095A, 0x5100, iwl7265_2ac_cfg)},
- {IWL_PCI_DEVICE(0x095A, 0x510A, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095B, 0x5310, iwl7265_2ac_cfg)},
- {IWL_PCI_DEVICE(0x095B, 0x5302, iwl7265_2ac_cfg)},
+ {IWL_PCI_DEVICE(0x095B, 0x5302, iwl7265_n_cfg)},
{IWL_PCI_DEVICE(0x095B, 0x5210, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095A, 0x5012, iwl7265_2ac_cfg)},
+ {IWL_PCI_DEVICE(0x095A, 0x5412, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095A, 0x5410, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095A, 0x5400, iwl7265_2ac_cfg)},
{IWL_PCI_DEVICE(0x095A, 0x1010, iwl7265_2ac_cfg)},
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: pull request: iwlwifi 2014-03-04
2014-03-04 17:35 pull request: iwlwifi 2014-03-04 Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 1/2] iwlwifi: mvm: don't WARN when statistics are handled late Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 2/2] iwlwifi: fix and add 7265 series HW IDs Emmanuel Grumbach
@ 2014-03-04 18:34 ` John W. Linville
2 siblings, 0 replies; 4+ messages in thread
From: John W. Linville @ 2014-03-04 18:34 UTC (permalink / raw)
To: Emmanuel Grumbach; +Cc: linux-wireless, ilw
On Tue, Mar 04, 2014 at 07:35:48PM +0200, Emmanuel Grumbach wrote:
> Hi John,
>
> One more fix and an update for device IDs.
> There is a bugzilla reported for the fix which is mentioned in the commit message.
>
> Please pull.
>
> emmanuel
>
> The following changes since commit 143582c6847cb285b361804c613127c25de60ca4:
>
> iwlwifi: fix TX status for aggregated packets (2014-02-27 10:28:03 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git for-john
>
> for you to fetch changes up to acfcd9ed588465e48efe5ceb67177096d51c95a9:
>
> iwlwifi: fix and add 7265 series HW IDs (2014-03-04 19:30:06 +0200)
Pulling now...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-04 18:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 17:35 pull request: iwlwifi 2014-03-04 Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 1/2] iwlwifi: mvm: don't WARN when statistics are handled late Emmanuel Grumbach
2014-03-04 17:36 ` [PATCH 2/2] iwlwifi: fix and add 7265 series HW IDs Emmanuel Grumbach
2014-03-04 18:34 ` pull request: iwlwifi 2014-03-04 John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).