linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: ath6kl@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 5/6] ath6kl: remove a warning on a macro
Date: Sun, 09 Mar 2014 08:57:35 +0200	[thread overview]
Message-ID: <20140309065735.10793.45835.stgit@x230> (raw)
In-Reply-To: <20140309065606.10793.67068.stgit@x230>

Fixes checkpatch warning:

WARNING: Single statement macros should not use a do {} while (0) loop

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/debug.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
index 55c4064..10a89cf 100644
--- a/drivers/net/wireless/ath/ath6kl/debug.c
+++ b/drivers/net/wireless/ath/ath6kl/debug.c
@@ -798,12 +798,10 @@ static ssize_t ath6kl_endpoint_stats_read(struct file *file,
 		return -ENOMEM;
 
 #define EPSTAT(name)							\
-	do {								\
-		len = print_endpoint_stat(target, buf, buf_len, len,	\
-					  offsetof(struct htc_endpoint_stats, \
-						   name),		\
-					  #name);			\
-	} while (0)
+	(len = print_endpoint_stat(target, buf, buf_len, len,		\
+				   offsetof(struct htc_endpoint_stats,	\
+					    name),			\
+				   #name))
 
 	EPSTAT(cred_low_indicate);
 	EPSTAT(tx_issued);


  parent reply	other threads:[~2014-03-09  6:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09  6:57 [PATCH 0/6] ath6kl: fixing new checkpatch warnings Kalle Valo
2014-03-09  6:57 ` [PATCH 1/6] ath6kl: fix blank lines before and after braces Kalle Valo
2014-03-09  6:57 ` [PATCH 2/6] ath6kl: use braces on both arms of if statement Kalle Valo
2014-03-09 21:42   ` Joe Perches
2014-03-10 17:23     ` Kalle Valo
2014-03-12  8:47     ` Jones Desougi
2014-03-12  8:52       ` Kalle Valo
2014-03-12 14:11         ` Joe Perches
2014-03-09  6:57 ` [PATCH 3/6] ath6kl: remove spaces before semicolon Kalle Valo
2014-03-09  6:57 ` [PATCH 4/6] ath6kl: remove unnecessary line continuations Kalle Valo
2014-03-09 21:15   ` Joe Perches
2014-03-10 17:26     ` Kalle Valo
2014-03-09  6:57 ` Kalle Valo [this message]
2014-03-09  7:10   ` [PATCH 5/6] ath6kl: remove a warning on a macro Kalle Valo
2014-03-09  7:20     ` Joe Perches
2014-03-09  7:44       ` Joe Perches
2014-03-10 17:29       ` Kalle Valo
2014-03-10 20:03         ` Joe Perches
2014-03-09  6:57 ` [PATCH 6/6] ath6kl: update Kconfig descriptions Kalle Valo
2014-03-13  5:48 ` [PATCH 0/6] ath6kl: fixing new checkpatch warnings Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140309065735.10793.45835.stgit@x230 \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).