[PATCH 1/4] rtl8180: change module name in rtl818Xpci

[PATCH 1/4] rtl8180: change module name in rtl818Xpci

[Andrea Merello]

From: Larry Finger <Larry.Finger@lwfinger.net>

rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
however in userspace tools (network manager) it still appares
as "rtl8180".
This might lead the user to think the wrong driver is in use.

This patch changes module name to "rtl818Xpci" that should be
more explanatory.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
---
 drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
index 08b056d..c74849d 100644
--- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
+++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
@@ -1,5 +1,5 @@
-rtl8180-objs		:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
+rtl818Xpci-objs		:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
 
-obj-$(CONFIG_RTL8180)	+= rtl8180.o
+obj-$(CONFIG_RTL8180)	+= rtl818Xpci.o
 
 ccflags-y += -Idrivers/net/wireless/rtl818x
-- 
1.8.3.2

Re: [PATCH 1/4] rtl8180: change module name in rtl818Xpci

[Kalle Valo]

Andrea Merello <andrea.merello@gmail.com> writes:

> From: Larry Finger <Larry.Finger@lwfinger.net>
>
> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
> however in userspace tools (network manager) it still appares
> as "rtl8180".
> This might lead the user to think the wrong driver is in use.
>
> This patch changes module name to "rtl818Xpci" that should be
> more explanatory.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>

[...]

> -obj-$(CONFIG_RTL8180)	+= rtl8180.o
> +obj-$(CONFIG_RTL8180)	+= rtl818Xpci.o

Aren't module names usually all lower case?

-- 
Kalle Valo

Re: [PATCH 1/4] rtl8180: change module name in rtl818Xpci

[Larry Finger]

On 04/04/2014 11:14 PM, Kalle Valo wrote:
> Andrea Merello <andrea.merello@gmail.com> writes:
>
>> From: Larry Finger <Larry.Finger@lwfinger.net>
>>
>> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
>> however in userspace tools (network manager) it still appares
>> as "rtl8180".
>> This might lead the user to think the wrong driver is in use.
>>
>> This patch changes module name to "rtl818Xpci" that should be
>> more explanatory.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>
> [...]
>
>> -obj-$(CONFIG_RTL8180)	+= rtl8180.o
>> +obj-$(CONFIG_RTL8180)	+= rtl818Xpci.o
>
> Aren't module names usually all lower case?

I do not feel strongly about this, but when I viewed the driver name in the KDE 
applet for NetworkManager, the lower-case x sort of got lost, whereas the 
upper-case one stood out. That was the reason for the way I wrote the patch the 
way I did. In a terminal, the lc value looks OK. Perhaps I should have made it 
rtl818x_pci.

Larry

Re: [PATCH 1/4] rtl8180: change module name in rtl818Xpci

[Kalle Valo]

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 04/04/2014 11:14 PM, Kalle Valo wrote:
>> Andrea Merello <andrea.merello@gmail.com> writes:
>>
>>> From: Larry Finger <Larry.Finger@lwfinger.net>
>>>
>>> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
>>> however in userspace tools (network manager) it still appares
>>> as "rtl8180".
>>> This might lead the user to think the wrong driver is in use.
>>>
>>> This patch changes module name to "rtl818Xpci" that should be
>>> more explanatory.
>>>
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>>
>> [...]
>>
>>> -obj-$(CONFIG_RTL8180)	+= rtl8180.o
>>> +obj-$(CONFIG_RTL8180)	+= rtl818Xpci.o
>>
>> Aren't module names usually all lower case?
>
> I do not feel strongly about this, but when I viewed the driver name
> in the KDE applet for NetworkManager, the lower-case x sort of got
> lost, whereas the upper-case one stood out. That was the reason for
> the way I wrote the patch the way I did. In a terminal, the lc value
> looks OK. 

I think it's confusing to use upper case letter in middle of a module
name. There's no way to remember that when you are typing it :)

I checked the ubuntu kernel 3.2.0-60-generic I had installed in this
machine. Out of 3311 kernel modules only 50 had upper case letters and
none of them were in drivers/net.

> Perhaps I should have made it rtl818x_pci.

That would be much more user friendly and also consistent with other
wireless drivers.

-- 
Kalle Valo

[PATCH v2 1/4] rtl8180: change module name in rtl818x_pci

[Andrea Merello]

From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]

rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
however in userspace tools (network manager) it still appares
as "rtl8180".
This might lead the user to think the wrong driver is in use.

This patch changes module name to "rtl818x_pci" that should be
more explanatory.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
---
 drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
index 08b056d..21005bd 100644
--- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
+++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
@@ -1,5 +1,5 @@
-rtl8180-objs		:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
+rtl818x_pci-objs	:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
 
-obj-$(CONFIG_RTL8180)	+= rtl8180.o
+obj-$(CONFIG_RTL8180)	+= rtl818x_pci.o
 
 ccflags-y += -Idrivers/net/wireless/rtl818x
-- 
1.8.3.2

Re: [PATCH v2 1/4] rtl8180: change module name in rtl818x_pci

[John W. Linville]

I see parts 1, 3, and 4/4.  Is there a part 2/4 that I missed?

On Tue, Apr 08, 2014 at 08:25:25PM +0200, Andrea Merello wrote:
> From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> 
> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
> however in userspace tools (network manager) it still appares
> as "rtl8180".
> This might lead the user to think the wrong driver is in use.
> 
> This patch changes module name to "rtl818x_pci" that should be
> more explanatory.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> ---
>  drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> index 08b056d..21005bd 100644
> --- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
> +++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> @@ -1,5 +1,5 @@
> -rtl8180-objs		:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
> +rtl818x_pci-objs	:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
>  
> -obj-$(CONFIG_RTL8180)	+= rtl8180.o
> +obj-$(CONFIG_RTL8180)	+= rtl818x_pci.o
>  
>  ccflags-y += -Idrivers/net/wireless/rtl818x
> -- 
> 1.8.3.2
> 
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH v2 1/4] rtl8180: change module name in rtl818x_pci

[Andrea Merello]

Yes, it is.
It seems that at least the wireless ML received it.
http://marc.info/?l=linux-wireless&m=139662852419525&w=2

BTW I can resend if you need it.

On Wed, Apr 9, 2014 at 6:10 PM, John W. Linville <linville@tuxdriver.com> wrote:
> I see parts 1, 3, and 4/4.  Is there a part 2/4 that I missed?
>
> On Tue, Apr 08, 2014 at 08:25:25PM +0200, Andrea Merello wrote:
>> From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
>>
>> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
>> however in userspace tools (network manager) it still appares
>> as "rtl8180".
>> This might lead the user to think the wrong driver is in use.
>>
>> This patch changes module name to "rtl818x_pci" that should be
>> more explanatory.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>> ---
>>  drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
>> index 08b056d..21005bd 100644
>> --- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
>> +++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
>> @@ -1,5 +1,5 @@
>> -rtl8180-objs         := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
>> +rtl818x_pci-objs     := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
>>
>> -obj-$(CONFIG_RTL8180)        += rtl8180.o
>> +obj-$(CONFIG_RTL8180)        += rtl818x_pci.o
>>
>>  ccflags-y += -Idrivers/net/wireless/rtl818x
>> --
>> 1.8.3.2
>>
>>
>
> --
> John W. Linville                Someday the world will need a hero, and you
> linville@tuxdriver.com                  might be all we have.  Be ready.

Re: [PATCH v2 1/4] rtl8180: change module name in rtl818x_pci

[John W. Linville]

NM, I've got them -- they just got sorted strangely in my mailbox...

On Wed, Apr 09, 2014 at 06:30:14PM +0200, Andrea Merello wrote:
> Yes, it is.
> It seems that at least the wireless ML received it.
> http://marc.info/?l=linux-wireless&m=139662852419525&w=2
> 
> BTW I can resend if you need it.
> 
> On Wed, Apr 9, 2014 at 6:10 PM, John W. Linville <linville@tuxdriver.com> wrote:
> > I see parts 1, 3, and 4/4.  Is there a part 2/4 that I missed?
> >
> > On Tue, Apr 08, 2014 at 08:25:25PM +0200, Andrea Merello wrote:
> >> From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> >>
> >> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
> >> however in userspace tools (network manager) it still appares
> >> as "rtl8180".
> >> This might lead the user to think the wrong driver is in use.
> >>
> >> This patch changes module name to "rtl818x_pci" that should be
> >> more explanatory.
> >>
> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> >> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> >> ---
> >>  drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> >> index 08b056d..21005bd 100644
> >> --- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
> >> +++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> >> @@ -1,5 +1,5 @@
> >> -rtl8180-objs         := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
> >> +rtl818x_pci-objs     := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
> >>
> >> -obj-$(CONFIG_RTL8180)        += rtl8180.o
> >> +obj-$(CONFIG_RTL8180)        += rtl818x_pci.o
> >>
> >>  ccflags-y += -Idrivers/net/wireless/rtl818x
> >> --
> >> 1.8.3.2
> >>
> >>
> >
> > --
> > John W. Linville                Someday the world will need a hero, and you
> > linville@tuxdriver.com                  might be all we have.  Be ready.
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.