From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Colin King <colin.king@canonical.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon
Date: Tue, 22 Apr 2014 13:59:19 -0400 [thread overview]
Message-ID: <20140422175919.GC16193@tuxdriver.com> (raw)
In-Reply-To: <53555240.70806@lwfinger.net>
On Mon, Apr 21, 2014 at 12:15:44PM -0500, Larry Finger wrote:
> On 04/21/2014 11:38 AM, Colin King wrote:
> >From: Colin Ian King <colin.king@canonical.com>
> >
> >static code analysis from cppcheck reports:
> >
> >[drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
> > (error) Uninitialized variable: packet_beacon
> >
> >packet_beacon is not initialized and hence packet_beacon
> >contains garbage from the stack, so set it to false.
> >
> >Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >---
> > drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This change should have a "Cc: Stable <stable@vger.kernel.org> [3.10+] notation.
>
> Other than that, Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> John: Is it possible for you to add stable, or do you want Colin to resubmit.
Got it, thanks...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2014-04-22 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 16:38 [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon Colin King
2014-04-21 17:15 ` Larry Finger
2014-04-22 17:59 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422175919.GC16193@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).