linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Michael Leun <lkml20140418@newton.leun.net>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
	johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	arik@wizery.com, linux@eikelenboom.it
Subject: Re: [PATCH 0/2] cfg80211: two reg fixes
Date: Tue, 22 Apr 2014 22:45:52 +0200	[thread overview]
Message-ID: <20140422204552.GR27882@wotan.suse.de> (raw)
In-Reply-To: <20140422180003.6438dbb7@xenia.leun.net>

On Tue, Apr 22, 2014 at 06:00:03PM +0200, Michael Leun wrote:
> On Mon, 21 Apr 2014 20:39:33 -0700
> "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
> 
> 
> 
> > that'd be appreciated as an alternative. I'm also very curious to hear
> > no one else would have run into the same regression as you have.
> 
> I only see this on an Acer PTZ1825 with an ath9k wireless card, but
> that machine was not sold with that wlan card, so other people with the
> same model won't neccesarily see the same issue.

OK I see the issue and its clear now how this could have
gone through, the wiphy comes from the country IE and it
could have gone disappearing during suspend / hotplug, so
we do need to check for it again.

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index f054137..4f375b6 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -1602,7 +1602,8 @@ __reg_process_hint_country_ie(struct wiphy *wiphy,
 			return REG_REQ_IGNORE;
 		return REG_REQ_ALREADY_SET;
 	} else {
-		if (wiphy->regulatory_flags & REGULATORY_COUNTRY_IE_IGNORE)
+		if (wiphy &&
+		    wiphy->regulatory_flags & REGULATORY_COUNTRY_IE_IGNORE)
 			return REG_REQ_IGNORE;
 	}
 

  parent reply	other threads:[~2014-04-22 20:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  3:39 [PATCH 0/2] cfg80211: two reg fixes Luis R. Rodriguez
2014-04-22  3:39 ` [PATCH 1/2] cfg80211: avoid freeing last_request while in flight Luis R. Rodriguez
2014-04-22 15:17   ` Johannes Berg
2014-04-22  3:39 ` [PATCH 2/2] cfg80211: fix processing world regdomain when non modular Luis R. Rodriguez
2014-04-22 15:18   ` Johannes Berg
2014-04-22 15:37     ` Sander Eikelenboom
2014-04-22 16:44       ` Luis R. Rodriguez
2014-09-02 12:00   ` Helmut Schaa
2014-09-05 21:43     ` Luis R. Rodriguez
2014-09-08  9:59       ` Helmut Schaa
2014-09-08 22:27         ` Luis R. Rodriguez
2014-04-22 16:00 ` [PATCH 0/2] cfg80211: two reg fixes Michael Leun
2014-04-22 16:32   ` Luis R. Rodriguez
2014-04-22 16:48     ` Michael Leun
2014-04-22 17:04       ` Luis R. Rodriguez
2014-04-22 17:30         ` Michael Leun
2014-04-22 17:38           ` Luis R. Rodriguez
2014-04-22 19:48             ` Michael Leun
2014-04-22 20:45   ` Luis R. Rodriguez [this message]
2014-04-22 21:32     ` Michael Leun
2014-04-22 21:50       ` Luis R. Rodriguez
2014-04-22 22:53         ` Michael Leun
2014-04-22 23:19           ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140422204552.GR27882@wotan.suse.de \
    --to=mcgrof@suse.com \
    --cc=arik@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@eikelenboom.it \
    --cc=lkml20140418@newton.leun.net \
    --cc=mcgrof@do-not-panic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).