From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail0.toppoint.de ([217.70.197.20]:55229 "EHLO mail0.toppoint.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758002AbaEKMtx convert rfc822-to-8bit (ORCPT ); Sun, 11 May 2014 08:49:53 -0400 Date: Sun, 11 May 2014 12:46:34 +0000 From: Wilfried Klaebe To: Anish Khurana Cc: "netdev@vger.kernel.org" , "David S. Miller" , linux-rdma@vger.kernel.org, linux-acenic@sunsite.dk, nios2-dev@lists.rocketboards.org, linuxppc-dev@lists.ozlabs.org, e1000-devel@lists.sourceforge.net, devel@linuxdriverproject.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-wireless@vger.kernel.org, xen-devel@lists.xenproject.org, linux-s390@vger.kernel.org, devel@driverdev.osuosl.org, b.a.t.m.a.n@lists.open-mesh.org, bridge@lists.linux-foundation.org, dev@openvswitch.org, trivial@kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS Message-ID: <20140511124633.GD7875@kaos.lebenslange-mailadresse.de> (sfid-20140511_145039_900408_BDEEB0DB) References: <20140511001231.GC7875@kaos.lebenslange-mailadresse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: Am Sun, May 11, 2014 at 01:13:47PM +0530 schrieb Anish Khurana: > SET_ETHTOOL_OPS is equivalent to : > #define SET_ETHTOOL_OPS(netdev,ops) \ > ( (netdev)->ethtool_ops = (ops) ) > > how it makes difference removing this code and replacing with the > code mentioned ? It doesn't change anything in the resulting binaries. The whole point is to remove the macro, which is something Dave wants to happen. Kind regards, Wilfried