From: Dan Carpenter <dan.carpenter@oracle.com>
To: Karim Raslan <karim.allah.ahmed@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Jes Sorensen <Jes.Sorensen@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int
Date: Mon, 19 May 2014 13:18:56 +0300 [thread overview]
Message-ID: <20140519101855.GU15585@mwanda> (raw)
In-Reply-To: <1400395256-8892-1-git-send-email-karim.allah.ahmed@gmail.com>
On Sun, May 18, 2014 at 07:39:23AM +0100, Karim Raslan wrote:
> This should fix a few sparse warnings like the following:
>
> CHECK drivers/staging/rtl8723au/core/rtw_ap.c
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in argument 3 (different base types)
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: expected int [signed] gfp
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: got restricted gfp_t
>
Thanks, Karim, looks good.
Jes's patch which added this never went to the list so I didn't review
it. This annoys me.
I try to be fair when I review code. I try to allow lots of patches in
and let people send fix up patches for minor stuff. But, obviously, you
should be running Sparse as part of the review process so if I made you
redo this patch it's because your process is broken. When I review
patches I am trying to help you.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-19 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 6:39 [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int Karim Raslan
2014-05-19 10:18 ` Dan Carpenter [this message]
2014-05-19 10:25 ` Jes Sorensen
2014-05-19 10:40 ` Dan Carpenter
2014-05-19 10:49 ` Jes Sorensen
2014-05-19 11:40 ` Dan Carpenter
2014-05-19 13:10 ` Jes Sorensen
2014-05-19 14:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519101855.GU15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=karim.allah.ahmed@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).