[PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Karim Raslan]

This should fix a few sparse warnings like the following:

  CHECK   drivers/staging/rtl8723au/core/rtw_ap.c
drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in argument 3 (different base types)
drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    expected int [signed] gfp
drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    got restricted gfp_t

Signed-off-by: Karim Raslan <karim.allah.ahmed@gmail.com>
---
 drivers/staging/rtl8723au/core/rtw_sta_mgt.c |    2 +-
 drivers/staging/rtl8723au/include/sta_info.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
index 7f1f66c..1ecfb87 100644
--- a/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723au/core/rtw_sta_mgt.c
@@ -106,7 +106,7 @@ u32	_rtw_free_sta_priv23a(struct	sta_priv *pstapriv)
 }
 
 struct sta_info *
-rtw_alloc_stainfo23a(struct sta_priv *pstapriv, u8 *hwaddr, int gfp)
+rtw_alloc_stainfo23a(struct sta_priv *pstapriv, u8 *hwaddr, gfp_t gfp)
 {
 	struct list_head	*phash_list;
 	struct sta_info	*psta;
diff --git a/drivers/staging/rtl8723au/include/sta_info.h b/drivers/staging/rtl8723au/include/sta_info.h
index 10d933e..e3bd31b 100644
--- a/drivers/staging/rtl8723au/include/sta_info.h
+++ b/drivers/staging/rtl8723au/include/sta_info.h
@@ -362,7 +362,7 @@ static inline u32 wifi_mac_hash(const u8 *mac)
 u32	_rtw_init_sta_priv23a(struct sta_priv *pstapriv);
 u32	_rtw_free_sta_priv23a(struct sta_priv *pstapriv);
 
-struct sta_info *rtw_alloc_stainfo23a(struct sta_priv *pstapriv, u8 *hwaddr, int gfp);
+struct sta_info *rtw_alloc_stainfo23a(struct sta_priv *pstapriv, u8 *hwaddr, gfp_t gfp);
 u32 rtw_free_stainfo23a(struct rtw_adapter *padapter, struct sta_info *psta);
 void rtw_free_all_stainfo23a(struct rtw_adapter *padapter);
 struct sta_info *rtw_get_stainfo23a(struct sta_priv *pstapriv, const u8 *hwaddr);
-- 
1.7.9.5

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Dan Carpenter]

On Sun, May 18, 2014 at 07:39:23AM +0100, Karim Raslan wrote:
> This should fix a few sparse warnings like the following:
> 
>   CHECK   drivers/staging/rtl8723au/core/rtw_ap.c
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect type in argument 3 (different base types)
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    expected int [signed] gfp
> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    got restricted gfp_t
> 

Thanks, Karim, looks good.

Jes's patch which added this never went to the list so I didn't review
it.  This annoys me.

I try to be fair when I review code.  I try to allow lots of patches in
and let people send fix up patches for minor stuff.  But, obviously, you
should be running Sparse as part of the review process so if I made you
redo this patch it's because your process is broken.  When I review
patches I am trying to help you.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Jes Sorensen]

Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Sun, May 18, 2014 at 07:39:23AM +0100, Karim Raslan wrote:
>> This should fix a few sparse warnings like the following:
>> 
>>   CHECK   drivers/staging/rtl8723au/core/rtw_ap.c
>> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45: warning: incorrect
>> type in argument 3 (different base types)
>> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    expected int [signed] gfp
>> drivers/staging/rtl8723au/core/rtw_ap.c:1054:45:    got restricted gfp_t
>> 
>
> Thanks, Karim, looks good.
>
> Jes's patch which added this never went to the list so I didn't review
> it.  This annoys me.
>
> I try to be fair when I review code.  I try to allow lots of patches in
> and let people send fix up patches for minor stuff.  But, obviously, you
> should be running Sparse as part of the review process so if I made you
> redo this patch it's because your process is broken.  When I review
> patches I am trying to help you.

Dan,

Calm down, I haven't been bombarding the list, due to the sheer volume
of commits.  If you want me to spam the list, tell me where and I'll add
that to the CC list next time.

This particular case isn't exactly a real problem either.

Jes

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Dan Carpenter]

On Mon, May 19, 2014 at 12:25:13PM +0200, Jes Sorensen wrote:
> Dan,
> 
> Calm down, I haven't been bombarding the list, due to the sheer volume
> of commits.  If you want me to spam the list, tell me where and I'll add
> that to the CC list next time.

We provide the scripts/get_maintainer.pl script for that.  You can leave
linux-kernel off if you want because they don't care about staging
drivers.  The staging list is devel@driverdev.osuosl.org.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Jes Sorensen]

Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Mon, May 19, 2014 at 12:25:13PM +0200, Jes Sorensen wrote:
>> Dan,
>> 
>> Calm down, I haven't been bombarding the list, due to the sheer volume
>> of commits.  If you want me to spam the list, tell me where and I'll add
>> that to the CC list next time.
>
> We provide the scripts/get_maintainer.pl script for that.  You can leave
> linux-kernel off if you want because they don't care about staging
> drivers.  The staging list is devel@driverdev.osuosl.org.

You should be running your tools against the staging tree automatically,
that way you catch it before it hits the mainline tree.

Just flooding mailing lists for the sake of flooding them doesn't add
any value either.

Jes

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Dan Carpenter]

On Mon, May 19, 2014 at 12:49:03PM +0200, Jes Sorensen wrote:
> You should be running your tools against the staging tree automatically,
> that way you catch it before it hits the mainline tree.
>
> Just flooding mailing lists for the sake of flooding them doesn't add
> any value either.

We are used to handling the traffic.  Heh.  Don't worry about us.  ;)

I don't actually run static analysis on staging patches until they hit
linux-next, I only review the mailing list patches manually.  My review
process is built around mailing lists so creating a special process for
rtl8723au makes my life harder instead of easier.  Every subsystem has a
review process, it's not that we are treating you unfairly by asking you
to send your patches for review.

Btw, Greg doesn't rebase the staging tree so, once a patch is merged,
then it means it will hit mainline.  At that point, it is too late to
send a second version of the patch.

You should be running Sparse yourself as part of your own QC tests
before submitting patches to review.  http://lwn.net/Articles/205624/
It is a normal minimum requirement along with checkpatch.pl.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Jes Sorensen]

Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Mon, May 19, 2014 at 12:49:03PM +0200, Jes Sorensen wrote:
>> You should be running your tools against the staging tree automatically,
>> that way you catch it before it hits the mainline tree.
>>
>> Just flooding mailing lists for the sake of flooding them doesn't add
>> any value either.
>
> We are used to handling the traffic.  Heh.  Don't worry about us.  ;)

I know how the traffic works, and I know I don't particularly like
flooding that I don't need to receive. I'll add
devel@driverdev.osuosl.org to the CC list next time.

> I don't actually run static analysis on staging patches until they hit
> linux-next, I only review the mailing list patches manually.  My review
> process is built around mailing lists so creating a special process for
> rtl8723au makes my life harder instead of easier.  Every subsystem has a
> review process, it's not that we are treating you unfairly by asking you
> to send your patches for review.

I am not suggesting you do it for the rtl8723au driver, I suggest you do
it as a general thing. I don't read devel@driverdev.osuosl.org either,
and like many other developers, I mostly gave up on lkml as well.

> Btw, Greg doesn't rebase the staging tree so, once a patch is merged,
> then it means it will hit mainline.  At that point, it is too late to
> send a second version of the patch.

I know, but I also know that I am not going to rebase my tree and
resubmit the full set, unless there is a strong reason for doing so.
As long as something sits in staging it's not really a showstopper if a
minor issue slips past and gets fixed up in a follow-on commit.

Jes

Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int

[Dan Carpenter]

Terrific, thanks.  :)

regards,
dan carpenter