From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Karim Raslan <karim.allah.ahmed@gmail.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int
Date: Mon, 19 May 2014 14:40:00 +0300 [thread overview]
Message-ID: <20140519114000.GW15585@mwanda> (raw)
In-Reply-To: <wrfjlhtyrqlc.fsf@ultrasam.lan.trained-monkey.org>
On Mon, May 19, 2014 at 12:49:03PM +0200, Jes Sorensen wrote:
> You should be running your tools against the staging tree automatically,
> that way you catch it before it hits the mainline tree.
>
> Just flooding mailing lists for the sake of flooding them doesn't add
> any value either.
We are used to handling the traffic. Heh. Don't worry about us. ;)
I don't actually run static analysis on staging patches until they hit
linux-next, I only review the mailing list patches manually. My review
process is built around mailing lists so creating a special process for
rtl8723au makes my life harder instead of easier. Every subsystem has a
review process, it's not that we are treating you unfairly by asking you
to send your patches for review.
Btw, Greg doesn't rebase the staging tree so, once a patch is merged,
then it means it will hit mainline. At that point, it is too late to
send a second version of the patch.
You should be running Sparse yourself as part of your own QC tests
before submitting patches to review. http://lwn.net/Articles/205624/
It is a normal minimum requirement along with checkpatch.pl.
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-19 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-18 6:39 [PATCH] staging: rtl8723au: rtw_sta_mgt: change rtw_alloc_stainfo23a to use gfp_t instead if int Karim Raslan
2014-05-19 10:18 ` Dan Carpenter
2014-05-19 10:25 ` Jes Sorensen
2014-05-19 10:40 ` Dan Carpenter
2014-05-19 10:49 ` Jes Sorensen
2014-05-19 11:40 ` Dan Carpenter [this message]
2014-05-19 13:10 ` Jes Sorensen
2014-05-19 14:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519114000.GW15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=karim.allah.ahmed@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).