From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 00/13] ath9k: Channel context support
Date: Wed, 4 Jun 2014 21:46:21 +0530 [thread overview]
Message-ID: <20140604161619.GA14852@qca.qualcomm.com> (raw)
In-Reply-To: <1401890446.6079.31.camel@jlt4.sipsolutions.net>
On Wed, Jun 04, 2014 at 04:00:46PM +0200, Johannes Berg wrote:
> On Wed, 2014-06-04 at 19:16 +0530, Rajkumar Manoharan wrote:
>
> > These patches adds a basic infrastruture for multi channel
> > context. Currently channel context usage is restricted by
> > modparam "use_chanctx" as it is not yet fully implemented.
>
> This isn't really a review - just a note. You should probably also tell
> mac80211 that you use multiple HW queues (at least per chanctx) so you
> avoid a situation where stopping one channel context leads to stopping
> the entire traffic for that AC even on other contexts, otherwise you
> could unfairly stop the other interface?
>
Completely agree. IEEE80211_HW_QUEUE_CONTROL support is still in-progress.
> I guess I'm also surprised by the implementation just switching from a
> worker, I would have thought you'd switch from a HW timer interrupt and
> use different hardware queues, but hey :)
>
These are just a preparatory changes for enabling MCC. The actual
scheduler is based on HW timers that will kickstart the worker thread.
Will post all of the changes after completing regression test cycle.
-Rajkumar
prev parent reply other threads:[~2014-06-04 16:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 13:46 [PATCH 00/13] ath9k: Channel context support Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 01/13] ath9k: Add channel context structure Rajkumar Manoharan
2014-06-09 11:36 ` Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 02/13] ath9k: Move txpower limit to channel context Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 03/13] ath9k: Move acq " Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 04/13] ath9k: Add channel context worker thread Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 05/13] ath9k: channel context based transmission Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 06/13] ath9k: send powersave frame on channel switch Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 07/13] ath9k: Implement hw_scan support Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 08/13] ath9k: Implement remain-on-channal support Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 09/13] ath9k: Implement channel context ops Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 10/13] ath9k: Fetch appropriate opereting channel context Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 11/13] ath9k: Move caldata into " Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 12/13] ath9k: Add ATH_OP_MULTI_CHANNEL Rajkumar Manoharan
2014-06-04 13:46 ` [PATCH 13/13] ath9k: save tsf in channel context Rajkumar Manoharan
2014-06-04 14:00 ` [PATCH 00/13] ath9k: Channel context support Johannes Berg
2014-06-04 16:16 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604161619.GA14852@qca.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).