linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] cfg80211: make ethtool the driver's responsibility
Date: Thu, 5 Jun 2014 11:14:40 -0400	[thread overview]
Message-ID: <20140605151440.GB3621@tuxdriver.com> (raw)
In-Reply-To: <1401896290-12942-1-git-send-email-johannes@sipsolutions.net>

On Wed, Jun 04, 2014 at 05:38:10PM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Currently, cfg80211 tries to implement ethtool, but that doesn't
> really scale well, with all the different operations. Make the
> lower-level driver responsible for it, which currently only has
> an effect on mac80211. It will similarly not scale well at that
> level though, since mac80211 also has many drivers.
> 
> To cleanly implement this in mac80211, introduce a new file and
> move some code to appropriate places.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Fine by me...

Acked-by: John W. Linville <linville@tuxdriver.com>

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2014-06-05 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 15:38 [PATCH] cfg80211: make ethtool the driver's responsibility Johannes Berg
2014-06-05 15:14 ` John W. Linville [this message]
2014-06-05 23:16 ` Bing Zhao
2014-06-06  6:10   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140605151440.GB3621@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).