Re: [PATCH 05/10] mac80211: use TDLS initiator in tdls_mgmt operations

[Jouni Malinen <j@w1.fi>]

On Sun, Jun 29, 2014 at 06:23:01PM +0300, Arik Nemtsov wrote:
> Well I have to say I didn't really consider mac80211 TDLS
> functionality "ready for prime time" when I've discovered this bug.
> It's something pretty basic.
> The breakage of older userspace was semi-deliberate here.

It may have lacked some functionality, but it is being deployed at least
in number of test setups.. Any such breakage of already exposed kernel
functionality needs to really be clearly identified in the commit
message, so that it is obvious to whoever may be reviewing the changes.

> But your logic is sound. If you consider this important, we can fix this.

I'm more concerned about non-mac80211 drivers since there are number of
those with TDLS support in deployed devices. However, ath9k enabled TDLS
support already in 2011 and as far as I know, it was working more or
less fine for single channel use cases since that point in time (even if
some of the teardown operations may have failed based on these new
patches and frames getting delivered through incorrect path, etc.).

While I may not be able to point to any specific deployment of
mac80211-based TDLS implementation, I don't think that it is acceptable
to break functionality that has been enabled for multiple years.. So
yes, I think that these patches will need to be fixed or reverted to
avoid such regressions.

-- 
Jouni Malinen                                            PGP id EFC895FA