From: Greg KH <greg@kroah.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: stable@vger.kernel.org, linux-wireless@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] brcmfmac: Fix brcmf_chip_ai_coredisable not applying reset bits to BCMA_IOCTL
Date: Fri, 4 Jul 2014 15:05:33 -0700 [thread overview]
Message-ID: <20140704220533.GA10958@kroah.com> (raw)
In-Reply-To: <1402091675-6515-1-git-send-email-arend@broadcom.com>
On Fri, Jun 06, 2014 at 11:54:31PM +0200, Arend van Spriel wrote:
> From: Hans de Goede <hdegoede@redhat.com>
>
> brcmfmac has been broken on my cubietruck with a BCM43362:
>
> brcmfmac: brcmf_chip_recognition: found AXI chip: BCM43362, rev=1
> brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0:
> Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01-b30a427d
>
> since commit 53036261033: "brcmfmac: update core reset and disable routines".
>
> The problem is that since this commit brcmf_chip_ai_resetcore no longer sets
> BCMA_IOCTL itself before bringing the core out of reset, instead relying on
> brcmf_chip_ai_coredisable to do so. But brcmf_chip_ai_coredisable is a nop
> of the chip is already in reset. This patch modifies brcmf_chip_ai_coredisable
> to always set BCMA_IOCTL even if the core is already in reset.
>
> This fixes brcmfmac hanging in firmware loading on my board.
>
> upstream: 75691d9e4f4e156f71f3eaee69a5bd27b7b10384
I see no such commit id in Linus's tree, are you sure this is the id you
need?
thanks,
greg k-h
next prev parent reply other threads:[~2014-07-04 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 21:54 [PATCH] brcmfmac: Fix brcmf_chip_ai_coredisable not applying reset bits to BCMA_IOCTL Arend van Spriel
2014-07-04 22:05 ` Greg KH [this message]
2014-07-05 8:33 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2014-04-23 10:20 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140704220533.GA10958@kroah.com \
--to=greg@kroah.com \
--cc=arend@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).