From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:37414 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754016AbaGRBrO (ORCPT ); Thu, 17 Jul 2014 21:47:14 -0400 Date: Thu, 17 Jul 2014 18:47:13 -0700 From: Greg Kroah-Hartman To: Kees Cook Cc: linux-kernel@vger.kernel.org, Ming Lei , "Luis R. Rodriguez" , James Morris , David Howells , linux-doc@vger.kernel.org, linux-security-module@vger.kernel.org, linux-firmware@kernel.org, linux-wireless Subject: Re: [PATCH 2/7] test: add firmware_class loader test Message-ID: <20140718014713.GA32594@kroah.com> (sfid-20140718_034731_133371_FEC1326F) References: <1405373897-31671-1-git-send-email-keescook@chromium.org> <1405373897-31671-3-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1405373897-31671-3-git-send-email-keescook@chromium.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jul 14, 2014 at 02:38:12PM -0700, Kees Cook wrote: > This provides a simple interface to trigger the firmware_class loader > to test built-in, filesystem, and user helper modes. Additionally adds > tests via the new interface to the selftests tree. > > Signed-off-by: Kees Cook > --- > lib/Kconfig.debug | 13 +++ > lib/Makefile | 1 + > lib/test_firmware.c | 117 +++++++++++++++++++++ Side note, I find it odd that in-kernel test modules are in lib/. But whatever, you aren't the one that did this first, so I'm not going to object here, I'll apply this, nice work. thanks, greg k-h