* Re: [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values. [not found] <1406732105-17500-1-git-send-email-martin.townsend@xsilon.com> @ 2014-07-30 17:42 ` Marcel Holtmann 2014-07-30 18:27 ` Alexander Aring 0 siblings, 1 reply; 6+ messages in thread From: Marcel Holtmann @ 2014-07-30 17:42 UTC (permalink / raw) To: Martin Townsend, John W. Linville, Alexander Aring Cc: linux-zigbee-devel, BlueZ development, Martin Townsend, Network Development, linux-wireless@vger.kernel.org Wireless Hi Martin, > Currently it is up to the functions below lowpan_rcv to free the skb on error > conditions. This patch now removes all the UAPI error codes and process data > now returns -1 if there is a problem. In this scenario lowpan_rcv will free > the skb and return NET_RX_DROP. This also fixes the problem where > NET_RX_SUCCESS is returned on error > > Martin Townsend (2): > Remove dev parameter from skb_delivery_cb in 6lowpan. > Change lowpan_rcv so skb is freed within function and fix return > values. > > include/net/6lowpan.h | 4 ++-- > net/6lowpan/iphc.c | 37 ++++++++++++++++++------------------ > net/bluetooth/6lowpan.c | 21 ++++++++++----------- > net/ieee802154/6lowpan_rtnl.c | 44 +++++++++++++++++++++---------------------- > 4 files changed, 52 insertions(+), 54 deletions(-) I can not take these patches at this point. checking file net/ieee802154/6lowpan_rtnl.c Hunk #1 FAILED at 143. Hunk #2 succeeded at 480 (offset -4 lines). 1 out of 2 hunks FAILED We need to get the IEEE 802.15.4 changes merged through John's wireless-next tree. IEEE 802.15.4 going straight into net-next and Bluetooth going into wireless-next will not work out smoothly when both technologies are now utilizing 6LoWPAN and we are heavily working on 6LoWPAN. John, how confident are you with pulling net-next into wireless-next at this point in time? Regards Marcel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values. 2014-07-30 17:42 ` [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values Marcel Holtmann @ 2014-07-30 18:27 ` Alexander Aring 2014-07-30 18:32 ` Marcel Holtmann 0 siblings, 1 reply; 6+ messages in thread From: Alexander Aring @ 2014-07-30 18:27 UTC (permalink / raw) To: Marcel Holtmann Cc: Martin Townsend, John W. Linville, linux-zigbee-devel, BlueZ development, Martin Townsend, Network Development, linux-wireless@vger.kernel.org Wireless Hi Marcel, On Wed, Jul 30, 2014 at 10:42:09AM -0700, Marcel Holtmann wrote: > Hi Martin, > > > Currently it is up to the functions below lowpan_rcv to free the skb on error > > conditions. This patch now removes all the UAPI error codes and process data > > now returns -1 if there is a problem. In this scenario lowpan_rcv will free > > the skb and return NET_RX_DROP. This also fixes the problem where > > NET_RX_SUCCESS is returned on error > > > > Martin Townsend (2): > > Remove dev parameter from skb_delivery_cb in 6lowpan. > > Change lowpan_rcv so skb is freed within function and fix return > > values. > > > > include/net/6lowpan.h | 4 ++-- > > net/6lowpan/iphc.c | 37 ++++++++++++++++++------------------ > > net/bluetooth/6lowpan.c | 21 ++++++++++----------- > > net/ieee802154/6lowpan_rtnl.c | 44 +++++++++++++++++++++---------------------- > > 4 files changed, 52 insertions(+), 54 deletions(-) > > I can not take these patches at this point. > > checking file net/ieee802154/6lowpan_rtnl.c > Hunk #1 FAILED at 143. > Hunk #2 succeeded at 480 (offset -4 lines). > 1 out of 2 hunks FAILED > > We need to get the IEEE 802.15.4 changes merged through John's wireless-next tree. IEEE 802.15.4 going straight into net-next and Bluetooth going into wireless-next will not work out smoothly when both technologies are now utilizing 6LoWPAN and we are heavily working on 6LoWPAN. > I already told Martin that these patches should be based on bluetooth (better bluetooth-next, 802.15.4 hasn't a real stable strategie and there are also some known other issues in the current implementation). I don't think that the current implementation is used in a real environment. I get this patch-series in a resend of this series, after Martin subscribed the linux-zigbee-devel mailinglist, then I told Martin that I need some time for review and he want to resend them tomorrow or friday. The resend should based on bluetooth-next then, if this is okay for you. I will cc bluetooth mailinglist in my review notes. - Alex ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values. 2014-07-30 18:27 ` Alexander Aring @ 2014-07-30 18:32 ` Marcel Holtmann 2014-07-31 13:59 ` John W. Linville 0 siblings, 1 reply; 6+ messages in thread From: Marcel Holtmann @ 2014-07-30 18:32 UTC (permalink / raw) To: Alexander Aring Cc: Martin Townsend, John W. Linville, linux-zigbee-devel, BlueZ development, Martin Townsend, Network Development, linux-wireless@vger.kernel.org Wireless Hi Alex, >>> Currently it is up to the functions below lowpan_rcv to free the skb on error >>> conditions. This patch now removes all the UAPI error codes and process data >>> now returns -1 if there is a problem. In this scenario lowpan_rcv will free >>> the skb and return NET_RX_DROP. This also fixes the problem where >>> NET_RX_SUCCESS is returned on error >>> >>> Martin Townsend (2): >>> Remove dev parameter from skb_delivery_cb in 6lowpan. >>> Change lowpan_rcv so skb is freed within function and fix return >>> values. >>> >>> include/net/6lowpan.h | 4 ++-- >>> net/6lowpan/iphc.c | 37 ++++++++++++++++++------------------ >>> net/bluetooth/6lowpan.c | 21 ++++++++++----------- >>> net/ieee802154/6lowpan_rtnl.c | 44 +++++++++++++++++++++---------------------- >>> 4 files changed, 52 insertions(+), 54 deletions(-) >> >> I can not take these patches at this point. >> >> checking file net/ieee802154/6lowpan_rtnl.c >> Hunk #1 FAILED at 143. >> Hunk #2 succeeded at 480 (offset -4 lines). >> 1 out of 2 hunks FAILED >> >> We need to get the IEEE 802.15.4 changes merged through John's wireless-next tree. IEEE 802.15.4 going straight into net-next and Bluetooth going into wireless-next will not work out smoothly when both technologies are now utilizing 6LoWPAN and we are heavily working on 6LoWPAN. >> > > I already told Martin that these patches should be based on bluetooth > (better bluetooth-next, 802.15.4 hasn't a real stable strategie and there > are also some known other issues in the current implementation). I don't > think that the current implementation is used in a real environment. > > I get this patch-series in a resend of this series, after Martin > subscribed the linux-zigbee-devel mailinglist, then I told Martin that I > need some time for review and he want to resend them tomorrow or friday. > The resend should based on bluetooth-next then, if this is okay for you. if patches are based on bluetooth-next, then we have no problem here. I can easily merge them. Regards Marcel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values. 2014-07-30 18:32 ` Marcel Holtmann @ 2014-07-31 13:59 ` John W. Linville 2014-07-31 14:07 ` Alexander Aring 2014-07-31 15:14 ` Marcel Holtmann 0 siblings, 2 replies; 6+ messages in thread From: John W. Linville @ 2014-07-31 13:59 UTC (permalink / raw) To: Marcel Holtmann Cc: Alexander Aring, Martin Townsend, linux-zigbee-devel, BlueZ development, Martin Townsend, Network Development, linux-wireless@vger.kernel.org Wireless On Wed, Jul 30, 2014 at 11:32:16AM -0700, Marcel Holtmann wrote: > Hi Alex, > > >>> Currently it is up to the functions below lowpan_rcv to free the skb on error > >>> conditions. This patch now removes all the UAPI error codes and process data > >>> now returns -1 if there is a problem. In this scenario lowpan_rcv will free > >>> the skb and return NET_RX_DROP. This also fixes the problem where > >>> NET_RX_SUCCESS is returned on error > >>> > >>> Martin Townsend (2): > >>> Remove dev parameter from skb_delivery_cb in 6lowpan. > >>> Change lowpan_rcv so skb is freed within function and fix return > >>> values. > >>> > >>> include/net/6lowpan.h | 4 ++-- > >>> net/6lowpan/iphc.c | 37 ++++++++++++++++++------------------ > >>> net/bluetooth/6lowpan.c | 21 ++++++++++----------- > >>> net/ieee802154/6lowpan_rtnl.c | 44 +++++++++++++++++++++---------------------- > >>> 4 files changed, 52 insertions(+), 54 deletions(-) > >> > >> I can not take these patches at this point. > >> > >> checking file net/ieee802154/6lowpan_rtnl.c > >> Hunk #1 FAILED at 143. > >> Hunk #2 succeeded at 480 (offset -4 lines). > >> 1 out of 2 hunks FAILED > >> > >> We need to get the IEEE 802.15.4 changes merged through John's wireless-next tree. IEEE 802.15.4 going straight into net-next and Bluetooth going into wireless-next will not work out smoothly when both technologies are now utilizing 6LoWPAN and we are heavily working on 6LoWPAN. > >> > > > > I already told Martin that these patches should be based on bluetooth > > (better bluetooth-next, 802.15.4 hasn't a real stable strategie and there > > are also some known other issues in the current implementation). I don't > > think that the current implementation is used in a real environment. > > > > I get this patch-series in a resend of this series, after Martin > > subscribed the linux-zigbee-devel mailinglist, then I told Martin that I > > need some time for review and he want to resend them tomorrow or friday. > > The resend should based on bluetooth-next then, if this is okay for you. > > if patches are based on bluetooth-next, then we have no problem here. I can easily merge them. Does that resolve it? That probably won't make 3.17, fwiw... -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values. 2014-07-31 13:59 ` John W. Linville @ 2014-07-31 14:07 ` Alexander Aring 2014-07-31 15:14 ` Marcel Holtmann 1 sibling, 0 replies; 6+ messages in thread From: Alexander Aring @ 2014-07-31 14:07 UTC (permalink / raw) To: John W. Linville Cc: Marcel Holtmann, Martin Townsend, linux-zigbee-devel, BlueZ development, Martin Townsend, Network Development, linux-wireless@vger.kernel.org Wireless Hi, On Thu, Jul 31, 2014 at 09:59:46AM -0400, John W. Linville wrote: > On Wed, Jul 30, 2014 at 11:32:16AM -0700, Marcel Holtmann wrote: > > Hi Alex, > > > > >>> Currently it is up to the functions below lowpan_rcv to free the skb on error > > >>> conditions. This patch now removes all the UAPI error codes and process data > > >>> now returns -1 if there is a problem. In this scenario lowpan_rcv will free > > >>> the skb and return NET_RX_DROP. This also fixes the problem where > > >>> NET_RX_SUCCESS is returned on error > > >>> > > >>> Martin Townsend (2): > > >>> Remove dev parameter from skb_delivery_cb in 6lowpan. > > >>> Change lowpan_rcv so skb is freed within function and fix return > > >>> values. > > >>> > > >>> include/net/6lowpan.h | 4 ++-- > > >>> net/6lowpan/iphc.c | 37 ++++++++++++++++++------------------ > > >>> net/bluetooth/6lowpan.c | 21 ++++++++++----------- > > >>> net/ieee802154/6lowpan_rtnl.c | 44 +++++++++++++++++++++---------------------- > > >>> 4 files changed, 52 insertions(+), 54 deletions(-) > > >> > > >> I can not take these patches at this point. > > >> > > >> checking file net/ieee802154/6lowpan_rtnl.c > > >> Hunk #1 FAILED at 143. > > >> Hunk #2 succeeded at 480 (offset -4 lines). > > >> 1 out of 2 hunks FAILED > > >> > > >> We need to get the IEEE 802.15.4 changes merged through John's wireless-next tree. IEEE 802.15.4 going straight into net-next and Bluetooth going into wireless-next will not work out smoothly when both technologies are now utilizing 6LoWPAN and we are heavily working on 6LoWPAN. > > >> > > > > > > I already told Martin that these patches should be based on bluetooth > > > (better bluetooth-next, 802.15.4 hasn't a real stable strategie and there > > > are also some known other issues in the current implementation). I don't > > > think that the current implementation is used in a real environment. > > > > > > I get this patch-series in a resend of this series, after Martin > > > subscribed the linux-zigbee-devel mailinglist, then I told Martin that I > > > need some time for review and he want to resend them tomorrow or friday. > > > The resend should based on bluetooth-next then, if this is okay for you. > > > > if patches are based on bluetooth-next, then we have no problem here. I can easily merge them. > > Does that resolve it? That probably won't make 3.17, fwiw... > there are some issues on this patch series. Martin need to work on and resend them as v2. I told about the issues on an another thread which should be the same series. I don't get exactly this patch series, I think Marcel add me in CC later. So it needs some time anyway. Thanks. - Alex ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values. 2014-07-31 13:59 ` John W. Linville 2014-07-31 14:07 ` Alexander Aring @ 2014-07-31 15:14 ` Marcel Holtmann 1 sibling, 0 replies; 6+ messages in thread From: Marcel Holtmann @ 2014-07-31 15:14 UTC (permalink / raw) To: John W. Linville Cc: Alexander Aring, Martin Townsend, linux-zigbee-devel, BlueZ development, Martin Townsend, Network Development, linux-wireless@vger.kernel.org Wireless Hi John, >>>>> Currently it is up to the functions below lowpan_rcv to free the skb on error >>>>> conditions. This patch now removes all the UAPI error codes and process data >>>>> now returns -1 if there is a problem. In this scenario lowpan_rcv will free >>>>> the skb and return NET_RX_DROP. This also fixes the problem where >>>>> NET_RX_SUCCESS is returned on error >>>>> >>>>> Martin Townsend (2): >>>>> Remove dev parameter from skb_delivery_cb in 6lowpan. >>>>> Change lowpan_rcv so skb is freed within function and fix return >>>>> values. >>>>> >>>>> include/net/6lowpan.h | 4 ++-- >>>>> net/6lowpan/iphc.c | 37 ++++++++++++++++++------------------ >>>>> net/bluetooth/6lowpan.c | 21 ++++++++++----------- >>>>> net/ieee802154/6lowpan_rtnl.c | 44 +++++++++++++++++++++---------------------- >>>>> 4 files changed, 52 insertions(+), 54 deletions(-) >>>> >>>> I can not take these patches at this point. >>>> >>>> checking file net/ieee802154/6lowpan_rtnl.c >>>> Hunk #1 FAILED at 143. >>>> Hunk #2 succeeded at 480 (offset -4 lines). >>>> 1 out of 2 hunks FAILED >>>> >>>> We need to get the IEEE 802.15.4 changes merged through John's wireless-next tree. IEEE 802.15.4 going straight into net-next and Bluetooth going into wireless-next will not work out smoothly when both technologies are now utilizing 6LoWPAN and we are heavily working on 6LoWPAN. >>>> >>> >>> I already told Martin that these patches should be based on bluetooth >>> (better bluetooth-next, 802.15.4 hasn't a real stable strategie and there >>> are also some known other issues in the current implementation). I don't >>> think that the current implementation is used in a real environment. >>> >>> I get this patch-series in a resend of this series, after Martin >>> subscribed the linux-zigbee-devel mailinglist, then I told Martin that I >>> need some time for review and he want to resend them tomorrow or friday. >>> The resend should based on bluetooth-next then, if this is okay for you. >> >> if patches are based on bluetooth-next, then we have no problem here. I can easily merge them. > > Does that resolve it? That probably won't make 3.17, fwiw... I agree that this is out of the question for 3.17 at this point in time. Johan send our last pull request which includes what we have for 6LoWPAN right now. Everything else needs to wait for 3.18. Regards Marcel ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-31 15:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1406732105-17500-1-git-send-email-martin.townsend@xsilon.com>
2014-07-30 17:42 ` [PATCH 0/2] linux-wpan-next: lowpan_rcv - skb is freed within function and fix return values Marcel Holtmann
2014-07-30 18:27 ` Alexander Aring
2014-07-30 18:32 ` Marcel Holtmann
2014-07-31 13:59 ` John W. Linville
2014-07-31 14:07 ` Alexander Aring
2014-07-31 15:14 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).