* [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string
@ 2014-08-04 0:20 Hans Wennborg
2014-08-25 20:18 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Hans Wennborg @ 2014-08-04 0:20 UTC (permalink / raw)
To: linville, linux-wireless, linux-kernel; +Cc: Hans Wennborg
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index c159c05..7d6fd59 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
else {
ret = il_set_tx_power(il, val, false);
if (ret)
- IL_ERR("failed setting tx power (0x%d).\n", ret);
+ IL_ERR("failed setting tx power (0x%x).\n", ret);
else
ret = count;
}
--
2.0.0.526.g5318336
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string
2014-08-04 0:20 [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string Hans Wennborg
@ 2014-08-25 20:18 ` John W. Linville
2014-09-06 3:41 ` [PATCH 1/1] " Hans Wennborg
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2014-08-25 20:18 UTC (permalink / raw)
To: Hans Wennborg; +Cc: linux-wireless, linux-kernel
On Sun, Aug 03, 2014 at 05:20:05PM -0700, Hans Wennborg wrote:
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
> index c159c05..7d6fd59 100644
> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
> @@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
> else {
> ret = il_set_tx_power(il, val, false);
> if (ret)
> - IL_ERR("failed setting tx power (0x%d).\n", ret);
> + IL_ERR("failed setting tx power (0x%x).\n", ret);
> else
> ret = count;
> }
It seems like that should be "0x%08x" or similar, no?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/1] iwl4965: fix %d confusingly prefixed with 0x in format string
2014-08-25 20:18 ` John W. Linville
@ 2014-09-06 3:41 ` Hans Wennborg
0 siblings, 0 replies; 3+ messages in thread
From: Hans Wennborg @ 2014-09-06 3:41 UTC (permalink / raw)
To: linville, linux-wireless, linux-kernel; +Cc: Hans Wennborg
Signed-off-by: Hans Wennborg <hans@hanshq.net>
---
drivers/net/wireless/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
index 3dcbe2c..cf7996f 100644
--- a/drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/iwlegacy/4965-mac.c
@@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr,
else {
ret = il_set_tx_power(il, val, false);
if (ret)
- IL_ERR("failed setting tx power (0x%d).\n", ret);
+ IL_ERR("failed setting tx power (0x%08x).\n", ret);
else
ret = count;
}
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-06 3:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 0:20 [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string Hans Wennborg
2014-08-25 20:18 ` John W. Linville
2014-09-06 3:41 ` [PATCH 1/1] " Hans Wennborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).