From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Sujith Manoharan <sujith@msujith.org>
Cc: John Linville <linville@tuxdriver.com>,
<linux-wireless@vger.kernel.org>, <ath9k-devel@qca.qualcomm.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "ath9k: Calculate sleep duration"
Date: Fri, 12 Sep 2014 11:39:38 +0530 [thread overview]
Message-ID: <20140912060936.GA20575@qca.qualcomm.com> (raw)
In-Reply-To: <21521.45335.848659.125183@gargle.gargle.HOWL>
On Thu, Sep 11, 2014 at 07:56:31PM +0530, Sujith Manoharan wrote:
> Rajkumar Manoharan wrote:
> > Some of the IOE customer using ath9k with power save enabled. IIRC the
> > expectation is that when the station is idle, it should wakeup on DTIM
> > beacon not for every beacons. Are you seeing frequest bmiss events on
> > higher beacon interval?
>
> I don't think ath9k has ever been tested with longer sleep durations
> based on dtim period. We have always programmed the hardware to wake up
> for every beacon interval, using the TIM_TIMER interrupt. And since the
> TIM bit needs to be checked for every beacon, the sleep duration has
> to be the beacon interval.
>
> Also, the bmiss threshold needs to be adjusted based on the sleep
> duration. We are hardcoding it currently in the driver using
> ATH_DEFAULT_BMISS_LIMIT. This will break, too.
>
> Using dtim for PS needs more testing before it can be used,
> so we can have the original behavior for now.
>
Sounds clear.
Acked-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
next prev parent reply other threads:[~2014-09-12 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 13:35 [PATCH] Revert "ath9k: Calculate sleep duration" Sujith Manoharan
2014-09-11 14:13 ` Rajkumar Manoharan
2014-09-11 14:26 ` Sujith Manoharan
2014-09-12 6:09 ` Rajkumar Manoharan [this message]
2014-09-12 6:18 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912060936.GA20575@qca.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@vger.kernel.org \
--cc=sujith@msujith.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).