Re: [PATCH v2] ath10k: add tracing for frame transmission

[Rajkumar Manoharan <rmanohar@qti.qualcomm.com>]

On Tue, Oct 07, 2014 at 07:19:05PM +0300, Kalle Valo wrote:
> Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> 
> > Add tracing support to forward management and data frames to
> > user space for packet inspection.
> >
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> 
> [...]
> 
> > --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> > +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> > @@ -291,6 +291,9 @@ static inline struct sk_buff *ath10k_htt_rx_netbuf_pop(struct ath10k_htt *htt)
> >  	htt->rx_ring.sw_rd_idx.msdu_payld = idx;
> >  	htt->rx_ring.fill_cnt--;
> >  
> > +	trace_ath10k_htt_rx_pop_msdu(ar, msdu->data, msdu->len +
> > +				     skb_tailroom(msdu));
> 
> Why add skb_tailroom() to the length? I think that deserves a comment.
>
It is used for rx crypto length. skb_tailroom is used in most of the
places even while dumping rx pkt by ath10k_dbg_dump.

-Rajkumar