From: Guenter Roeck <linux@roeck-us.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hauke Mehrtens <hauke@hauke-m.de>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] bcma: Add dependency on OF_ADDRESS
Date: Thu, 9 Oct 2014 10:15:24 -0700 [thread overview]
Message-ID: <20141009171523.GA2410@roeck-us.net> (raw)
In-Reply-To: <CACna6rzOeGcKrrftLx_3uWe_bAXQaQMmWb3wWHP0CjtdO8D0eg@mail.gmail.com>
On Thu, Oct 09, 2014 at 06:54:48PM +0200, Rafał Miłecki wrote:
> On 9 October 2014 18:41, Guenter Roeck <linux@roeck-us.net> wrote:
> > Commit 2101e533f41a ("bcma: register bcma as device tree driver")
> > introduces a hard dependency on OF_ADDRESS into the bcma driver.
> > OF_ADDRESS is specifically disabled for the sparc architecture.
> > This results in the following error when building sparc64:allmodconfig.
>
> Won't this make bcma im-POSSIBLE on MIPS? And maybe x86(_64), or at
> least add an unneeded dependency? I think we should somehow limit this
> to BCM5301X arch.
sparc, not mips.
Something like "depends on !OF || OF_ADDRESS" would limit the impact to
sparc, and only if OF is configured as well. I'll update accordingly
and resubmit. Everything else would have to be done in the driver itself,
which I rather not touch myself.
Guenter
next prev parent reply other threads:[~2014-10-09 17:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-09 16:41 [PATCH] bcma: Add dependency on OF_ADDRESS Guenter Roeck
2014-10-09 16:54 ` Rafał Miłecki
2014-10-09 17:15 ` Guenter Roeck [this message]
2014-10-09 17:15 ` Arend van Spriel
2014-10-09 17:18 ` Arend van Spriel
2014-10-09 17:29 ` Guenter Roeck
2014-10-09 18:28 ` Hauke Mehrtens
2014-10-09 19:25 ` Guenter Roeck
2014-10-09 21:48 ` Hauke Mehrtens
2014-10-09 21:57 ` Guenter Roeck
2014-10-10 9:30 ` Arend van Spriel
2014-10-09 21:39 ` [PATCH] bcma: fix build when CONFIG_OF_ADDRESS is not set Hauke Mehrtens
2014-10-09 21:46 ` Guenter Roeck
2014-10-25 20:36 ` Guenter Roeck
2014-10-27 15:15 ` John W. Linville
2014-10-27 15:42 ` Guenter Roeck
2014-10-09 17:21 ` [PATCH] bcma: Add dependency on OF_ADDRESS Guenter Roeck
2014-10-10 0:24 ` Julian Calaby
2014-10-10 4:32 ` David Miller
2014-10-09 17:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009171523.GA2410@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).