* PROBLEM: Boot failure with bad RIP value
@ 2014-10-13 23:45 S. Gilles
2014-10-14 3:41 ` Larry Finger
0 siblings, 1 reply; 7+ messages in thread
From: S. Gilles @ 2014-10-13 23:45 UTC (permalink / raw)
To: Larry Finger, Chaoming Li; +Cc: linux-wireless
(Sending this to the right people this time, hopefully.)
I have been getting a consistent boot failure with 3.17, which I have
bisected to
38506ecefab911785d5e1aa5889f6eeb462e0954 is the first bad commit
commit 38506ecefab911785d5e1aa5889f6eeb462e0954
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date: Mon Sep 22 09:39:19 2014 -0500
rtlwifi: rtl_pci: Start modification for new drivers
Future patches will move the drivers for RTL8192EE and RTL8821AE
from staging to the regular wireless tree. Here, the necessary features
are added to the PCI driver. Other files are touched due to changes
in the various data structs.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
The end of the trace (hand-retyped, so there may be errors that
escaped me):
R10: ffffffff825f2d80 R11: 0000000000000000 R12: ffff8800b4f107c0
R13: ffff8800b4f124b8 R14: 0000000000001000 R15: ffff8800b4c7a000
FS: 000007fc66c938700(0000) GS:ffff88013e200000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 00000000b5438000 CR4: 00000000000407f0
Stack:
ffffffffa01e20d6 ffff8800b4f12420 ffff8800b4f107c0 ffff880137d7fcd0
ffffffffa01c97b5 ffff8800b4f107c0 ffff8800b4c7a8d0 0000000000000000
ffff880137d7fd30 ffffffff81577304 0000000000000000 ffff8800b4c7a8c0
Call Trace:
[<ffffffffa01e20d6>] ? rtl_pci_start+0x2b/0x15f [rtl_pci]
[<ffffffffa01c97b5>] rtl_op_start+0x45/0x64 [rtlwifi]
[<ffffffff81577304>] ieee80211_do_open+0x152/0xb4b
[<ffffffff815b52bc>] ? mutex_unlock+0x9/0xb
[<ffffffff81577d4a>] ieee80211_open+0x4d/0x57
[<ffffffff8147df7f>] __dev_open+0x8b/0xcb
[<ffffffff8147e1e1>] __dev_change_flags+0xa4/0x13a
[<ffffffff8147e297>] dev_change_flags+0x20/0x53
[<ffffffff814d0204>] devinet_ioctl+0x269/0x568
[<ffffffff814d19b4>] inet_ioctl+0x81/0x9e
[<ffffffff814654e6>] sock_do_ioctl+0x20/0x3d
[<ffffffff81465a56>] sock_ioctl+0x20e/0x21a
[<ffffffff81136242>] do_vfs_ioctl+0x39e/0x467
[<ffffffff815b7277>] ? sysret_check+0x1b/0x56
[<ffffffff810965fe>] ? trace_hardirqs_on_caller+0x16e/0x18a
[<ffffffff81136343>] SyS_ioctl+0x38/0x5f
[<ffffffff815b7252>] system_call_fastpath+0x16/0x1b
Code: Bad RIP value.
RIP [< (null)>] (null)
RSP <ffff880137d7fc90>
CR2: 0000000000000000
---[ end trace 7307d2524c1e640b ]---
This is extremely easy to test (boot) and seems 100% reproducible.
I have submitted Bug 86211 - Boot failure: Bad RIP value for rtl8192ce
for this issue.
Thanks,
S. Gilles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PROBLEM: Boot failure with bad RIP value
2014-10-13 23:45 PROBLEM: Boot failure with bad RIP value S. Gilles
@ 2014-10-14 3:41 ` Larry Finger
2014-10-14 4:13 ` S. Gilles
0 siblings, 1 reply; 7+ messages in thread
From: Larry Finger @ 2014-10-14 3:41 UTC (permalink / raw)
To: S. Gilles, Chaoming Li; +Cc: linux-wireless
On 10/13/2014 06:45 PM, S. Gilles wrote:
> (Sending this to the right people this time, hopefully.)
>
> I have been getting a consistent boot failure with 3.17, which I have
> bisected to
>
> 38506ecefab911785d5e1aa5889f6eeb462e0954 is the first bad commit
> commit 38506ecefab911785d5e1aa5889f6eeb462e0954
> Author: Larry Finger <Larry.Finger@lwfinger.net>
> Date: Mon Sep 22 09:39:19 2014 -0500
>
> rtlwifi: rtl_pci: Start modification for new drivers
>
> Future patches will move the drivers for RTL8192EE and RTL8821AE
> from staging to the regular wireless tree. Here, the necessary features
> are added to the PCI driver. Other files are touched due to changes
> in the various data structs.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> The end of the trace (hand-retyped, so there may be errors that
> escaped me):
>
> R10: ffffffff825f2d80 R11: 0000000000000000 R12: ffff8800b4f107c0
> R13: ffff8800b4f124b8 R14: 0000000000001000 R15: ffff8800b4c7a000
> FS: 000007fc66c938700(0000) GS:ffff88013e200000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000000 CR3: 00000000b5438000 CR4: 00000000000407f0
> Stack:
> ffffffffa01e20d6 ffff8800b4f12420 ffff8800b4f107c0 ffff880137d7fcd0
> ffffffffa01c97b5 ffff8800b4f107c0 ffff8800b4c7a8d0 0000000000000000
> ffff880137d7fd30 ffffffff81577304 0000000000000000 ffff8800b4c7a8c0
> Call Trace:
> [<ffffffffa01e20d6>] ? rtl_pci_start+0x2b/0x15f [rtl_pci]
> [<ffffffffa01c97b5>] rtl_op_start+0x45/0x64 [rtlwifi]
> [<ffffffff81577304>] ieee80211_do_open+0x152/0xb4b
> [<ffffffff815b52bc>] ? mutex_unlock+0x9/0xb
> [<ffffffff81577d4a>] ieee80211_open+0x4d/0x57
> [<ffffffff8147df7f>] __dev_open+0x8b/0xcb
> [<ffffffff8147e1e1>] __dev_change_flags+0xa4/0x13a
> [<ffffffff8147e297>] dev_change_flags+0x20/0x53
> [<ffffffff814d0204>] devinet_ioctl+0x269/0x568
> [<ffffffff814d19b4>] inet_ioctl+0x81/0x9e
> [<ffffffff814654e6>] sock_do_ioctl+0x20/0x3d
> [<ffffffff81465a56>] sock_ioctl+0x20e/0x21a
> [<ffffffff81136242>] do_vfs_ioctl+0x39e/0x467
> [<ffffffff815b7277>] ? sysret_check+0x1b/0x56
> [<ffffffff810965fe>] ? trace_hardirqs_on_caller+0x16e/0x18a
> [<ffffffff81136343>] SyS_ioctl+0x38/0x5f
> [<ffffffff815b7252>] system_call_fastpath+0x16/0x1b
> Code: Bad RIP value.
> RIP [< (null)>] (null)
> RSP <ffff880137d7fc90>
> CR2: 0000000000000000
> ---[ end trace 7307d2524c1e640b ]---
>
> This is extremely easy to test (boot) and seems 100% reproducible.
>
> I have submitted Bug 86211 - Boot failure: Bad RIP value for rtl8192ce
> for this issue.
I am traveling and it may be a few days before I am able to make a suitable
test. In the meantime, please post the appropriate stanza for the Realtek device
from the output of
lspci -nn
There are several different devices that use driver rtl8192ce, and I need to
know which one you have so that I can duplicate the problem.
Larry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PROBLEM: Boot failure with bad RIP value
2014-10-14 3:41 ` Larry Finger
@ 2014-10-14 4:13 ` S. Gilles
2014-10-21 22:35 ` S. Gilles
2014-10-31 13:56 ` S. Gilles
0 siblings, 2 replies; 7+ messages in thread
From: S. Gilles @ 2014-10-14 4:13 UTC (permalink / raw)
To: Larry Finger; +Cc: S. Gilles, Chaoming Li, linux-wireless
On Mon, Oct 13, 2014 at 10:41:26PM -0500, Larry Finger wrote:
> On 10/13/2014 06:45 PM, S. Gilles wrote:
> > (Sending this to the right people this time, hopefully.)
> >
> > I have been getting a consistent boot failure with 3.17, which I have
> > bisected to
> >
> > 38506ecefab911785d5e1aa5889f6eeb462e0954 is the first bad commit
> > commit 38506ecefab911785d5e1aa5889f6eeb462e0954
> > Author: Larry Finger <Larry.Finger@lwfinger.net>
> > Date: Mon Sep 22 09:39:19 2014 -0500
> >
> > rtlwifi: rtl_pci: Start modification for new drivers
> >
> > Future patches will move the drivers for RTL8192EE and RTL8821AE
> > from staging to the regular wireless tree. Here, the necessary features
> > are added to the PCI driver. Other files are touched due to changes
> > in the various data structs.
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> >
> > The end of the trace (hand-retyped, so there may be errors that
> > escaped me):
> >
> > R10: ffffffff825f2d80 R11: 0000000000000000 R12: ffff8800b4f107c0
> > R13: ffff8800b4f124b8 R14: 0000000000001000 R15: ffff8800b4c7a000
> > FS: 000007fc66c938700(0000) GS:ffff88013e200000(0000) knlGS:0000000000000000
> > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > CR2: 0000000000000000 CR3: 00000000b5438000 CR4: 00000000000407f0
> > Stack:
> > ffffffffa01e20d6 ffff8800b4f12420 ffff8800b4f107c0 ffff880137d7fcd0
> > ffffffffa01c97b5 ffff8800b4f107c0 ffff8800b4c7a8d0 0000000000000000
> > ffff880137d7fd30 ffffffff81577304 0000000000000000 ffff8800b4c7a8c0
> > Call Trace:
> > [<ffffffffa01e20d6>] ? rtl_pci_start+0x2b/0x15f [rtl_pci]
> > [<ffffffffa01c97b5>] rtl_op_start+0x45/0x64 [rtlwifi]
> > [<ffffffff81577304>] ieee80211_do_open+0x152/0xb4b
> > [<ffffffff815b52bc>] ? mutex_unlock+0x9/0xb
> > [<ffffffff81577d4a>] ieee80211_open+0x4d/0x57
> > [<ffffffff8147df7f>] __dev_open+0x8b/0xcb
> > [<ffffffff8147e1e1>] __dev_change_flags+0xa4/0x13a
> > [<ffffffff8147e297>] dev_change_flags+0x20/0x53
> > [<ffffffff814d0204>] devinet_ioctl+0x269/0x568
> > [<ffffffff814d19b4>] inet_ioctl+0x81/0x9e
> > [<ffffffff814654e6>] sock_do_ioctl+0x20/0x3d
> > [<ffffffff81465a56>] sock_ioctl+0x20e/0x21a
> > [<ffffffff81136242>] do_vfs_ioctl+0x39e/0x467
> > [<ffffffff815b7277>] ? sysret_check+0x1b/0x56
> > [<ffffffff810965fe>] ? trace_hardirqs_on_caller+0x16e/0x18a
> > [<ffffffff81136343>] SyS_ioctl+0x38/0x5f
> > [<ffffffff815b7252>] system_call_fastpath+0x16/0x1b
> > Code: Bad RIP value.
> > RIP [< (null)>] (null)
> > RSP <ffff880137d7fc90>
> > CR2: 0000000000000000
> > ---[ end trace 7307d2524c1e640b ]---
> >
> > This is extremely easy to test (boot) and seems 100% reproducible.
> >
> > I have submitted Bug 86211 - Boot failure: Bad RIP value for rtl8192ce
> > for this issue.
>
> I am traveling and it may be a few days before I am able to make a suitable
> test. In the meantime, please post the appropriate stanza for the Realtek device
> from the output of
>
> lspci -nn
>
> There are several different devices that use driver rtl8192ce, and I need to
> know which one you have so that I can duplicate the problem.
Of course - I definitely should have mentioned that.
$ lspci -nn | grep RTL
03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8188CE 802.11b/g/n WiFi Adapter [10ec:8176] (rev 01)
--
S. Gilles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PROBLEM: Boot failure with bad RIP value
2014-10-14 4:13 ` S. Gilles
@ 2014-10-21 22:35 ` S. Gilles
2014-10-31 13:56 ` S. Gilles
1 sibling, 0 replies; 7+ messages in thread
From: S. Gilles @ 2014-10-21 22:35 UTC (permalink / raw)
To: S. Gilles; +Cc: Larry Finger, Chaoming Li, linux-wireless
On Tue, Oct 14, 2014 at 12:13:13AM -0400, S. Gilles wrote:
> On Mon, Oct 13, 2014 at 10:41:26PM -0500, Larry Finger wrote:
> > On 10/13/2014 06:45 PM, S. Gilles wrote:
> > > (Sending this to the right people this time, hopefully.)
> > >
> > > I have been getting a consistent boot failure with 3.17, which I have
> > > bisected to
> > >
> > > 38506ecefab911785d5e1aa5889f6eeb462e0954 is the first bad commit
> > > commit 38506ecefab911785d5e1aa5889f6eeb462e0954
> > > Author: Larry Finger <Larry.Finger@lwfinger.net>
> > > Date: Mon Sep 22 09:39:19 2014 -0500
> > >
> > > rtlwifi: rtl_pci: Start modification for new drivers
> > >
> > > Future patches will move the drivers for RTL8192EE and RTL8821AE
> > > from staging to the regular wireless tree. Here, the necessary features
> > > are added to the PCI driver. Other files are touched due to changes
> > > in the various data structs.
> > >
> > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > >
> > > The end of the trace (hand-retyped, so there may be errors that
> > > escaped me):
> > >
> > > R10: ffffffff825f2d80 R11: 0000000000000000 R12: ffff8800b4f107c0
> > > R13: ffff8800b4f124b8 R14: 0000000000001000 R15: ffff8800b4c7a000
> > > FS: 000007fc66c938700(0000) GS:ffff88013e200000(0000) knlGS:0000000000000000
> > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > CR2: 0000000000000000 CR3: 00000000b5438000 CR4: 00000000000407f0
> > > Stack:
> > > ffffffffa01e20d6 ffff8800b4f12420 ffff8800b4f107c0 ffff880137d7fcd0
> > > ffffffffa01c97b5 ffff8800b4f107c0 ffff8800b4c7a8d0 0000000000000000
> > > ffff880137d7fd30 ffffffff81577304 0000000000000000 ffff8800b4c7a8c0
> > > Call Trace:
> > > [<ffffffffa01e20d6>] ? rtl_pci_start+0x2b/0x15f [rtl_pci]
> > > [<ffffffffa01c97b5>] rtl_op_start+0x45/0x64 [rtlwifi]
> > > [<ffffffff81577304>] ieee80211_do_open+0x152/0xb4b
> > > [<ffffffff815b52bc>] ? mutex_unlock+0x9/0xb
> > > [<ffffffff81577d4a>] ieee80211_open+0x4d/0x57
> > > [<ffffffff8147df7f>] __dev_open+0x8b/0xcb
> > > [<ffffffff8147e1e1>] __dev_change_flags+0xa4/0x13a
> > > [<ffffffff8147e297>] dev_change_flags+0x20/0x53
> > > [<ffffffff814d0204>] devinet_ioctl+0x269/0x568
> > > [<ffffffff814d19b4>] inet_ioctl+0x81/0x9e
> > > [<ffffffff814654e6>] sock_do_ioctl+0x20/0x3d
> > > [<ffffffff81465a56>] sock_ioctl+0x20e/0x21a
> > > [<ffffffff81136242>] do_vfs_ioctl+0x39e/0x467
> > > [<ffffffff815b7277>] ? sysret_check+0x1b/0x56
> > > [<ffffffff810965fe>] ? trace_hardirqs_on_caller+0x16e/0x18a
> > > [<ffffffff81136343>] SyS_ioctl+0x38/0x5f
> > > [<ffffffff815b7252>] system_call_fastpath+0x16/0x1b
> > > Code: Bad RIP value.
> > > RIP [< (null)>] (null)
> > > RSP <ffff880137d7fc90>
> > > CR2: 0000000000000000
> > > ---[ end trace 7307d2524c1e640b ]---
> > >
> > > This is extremely easy to test (boot) and seems 100% reproducible.
> > >
> > > I have submitted Bug 86211 - Boot failure: Bad RIP value for rtl8192ce
> > > for this issue.
> >
> > I am traveling and it may be a few days before I am able to make a suitable
> > test. In the meantime, please post the appropriate stanza for the Realtek device
> > from the output of
> >
> > lspci -nn
> >
> > There are several different devices that use driver rtl8192ce, and I need to
> > know which one you have so that I can duplicate the problem.
>
> Of course - I definitely should have mentioned that.
>
> $ lspci -nn | grep RTL
> 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8188CE 802.11b/g/n WiFi Adapter [10ec:8176] (rev 01)
Ping for this, just to make sure it doesn't fall off the radar.
--
S. Gilles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PROBLEM: Boot failure with bad RIP value
2014-10-14 4:13 ` S. Gilles
2014-10-21 22:35 ` S. Gilles
@ 2014-10-31 13:56 ` S. Gilles
2014-10-31 15:07 ` Larry Finger
1 sibling, 1 reply; 7+ messages in thread
From: S. Gilles @ 2014-10-31 13:56 UTC (permalink / raw)
To: Larry Finger; +Cc: S. Gilles, Chaoming Li, linux-wireless
On Tue, Oct 14, 2014 at 12:13:13AM -0400, S. Gilles wrote:
> On Mon, Oct 13, 2014 at 10:41:26PM -0500, Larry Finger wrote:
> > On 10/13/2014 06:45 PM, S. Gilles wrote:
> > > (Sending this to the right people this time, hopefully.)
> > >
> > > I have been getting a consistent boot failure with 3.17, which I have
> > > bisected to
> > >
> > > 38506ecefab911785d5e1aa5889f6eeb462e0954 is the first bad commit
> > > commit 38506ecefab911785d5e1aa5889f6eeb462e0954
> > > Author: Larry Finger <Larry.Finger@lwfinger.net>
> > > Date: Mon Sep 22 09:39:19 2014 -0500
> > >
> > > rtlwifi: rtl_pci: Start modification for new drivers
> > >
> > > Future patches will move the drivers for RTL8192EE and RTL8821AE
> > > from staging to the regular wireless tree. Here, the necessary features
> > > are added to the PCI driver. Other files are touched due to changes
> > > in the various data structs.
> > >
> > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > >
> > > The end of the trace (hand-retyped, so there may be errors that
> > > escaped me):
> > >
> > > R10: ffffffff825f2d80 R11: 0000000000000000 R12: ffff8800b4f107c0
> > > R13: ffff8800b4f124b8 R14: 0000000000001000 R15: ffff8800b4c7a000
> > > FS: 000007fc66c938700(0000) GS:ffff88013e200000(0000) knlGS:0000000000000000
> > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > > CR2: 0000000000000000 CR3: 00000000b5438000 CR4: 00000000000407f0
> > > Stack:
> > > ffffffffa01e20d6 ffff8800b4f12420 ffff8800b4f107c0 ffff880137d7fcd0
> > > ffffffffa01c97b5 ffff8800b4f107c0 ffff8800b4c7a8d0 0000000000000000
> > > ffff880137d7fd30 ffffffff81577304 0000000000000000 ffff8800b4c7a8c0
> > > Call Trace:
> > > [<ffffffffa01e20d6>] ? rtl_pci_start+0x2b/0x15f [rtl_pci]
> > > [<ffffffffa01c97b5>] rtl_op_start+0x45/0x64 [rtlwifi]
> > > [<ffffffff81577304>] ieee80211_do_open+0x152/0xb4b
> > > [<ffffffff815b52bc>] ? mutex_unlock+0x9/0xb
> > > [<ffffffff81577d4a>] ieee80211_open+0x4d/0x57
> > > [<ffffffff8147df7f>] __dev_open+0x8b/0xcb
> > > [<ffffffff8147e1e1>] __dev_change_flags+0xa4/0x13a
> > > [<ffffffff8147e297>] dev_change_flags+0x20/0x53
> > > [<ffffffff814d0204>] devinet_ioctl+0x269/0x568
> > > [<ffffffff814d19b4>] inet_ioctl+0x81/0x9e
> > > [<ffffffff814654e6>] sock_do_ioctl+0x20/0x3d
> > > [<ffffffff81465a56>] sock_ioctl+0x20e/0x21a
> > > [<ffffffff81136242>] do_vfs_ioctl+0x39e/0x467
> > > [<ffffffff815b7277>] ? sysret_check+0x1b/0x56
> > > [<ffffffff810965fe>] ? trace_hardirqs_on_caller+0x16e/0x18a
> > > [<ffffffff81136343>] SyS_ioctl+0x38/0x5f
> > > [<ffffffff815b7252>] system_call_fastpath+0x16/0x1b
> > > Code: Bad RIP value.
> > > RIP [< (null)>] (null)
> > > RSP <ffff880137d7fc90>
> > > CR2: 0000000000000000
> > > ---[ end trace 7307d2524c1e640b ]---
> > >
> > > This is extremely easy to test (boot) and seems 100% reproducible.
> > >
> > > I have submitted Bug 86211 - Boot failure: Bad RIP value for rtl8192ce
> > > for this issue.
> >
> > I am traveling and it may be a few days before I am able to make a suitable
> > test. In the meantime, please post the appropriate stanza for the Realtek device
> > from the output of
> >
> > lspci -nn
> >
> > There are several different devices that use driver rtl8192ce, and I need to
> > know which one you have so that I can duplicate the problem.
>
> Of course - I definitely should have mentioned that.
>
> $ lspci -nn | grep RTL
> 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8188CE 802.11b/g/n WiFi Adapter [10ec:8176] (rev 01)
Any progress on this, or duplication? If this isn't replicable with
the information in Bugzilla, I can provide anything requested.
--
S. Gilles
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: PROBLEM: Boot failure with bad RIP value
2014-10-31 13:56 ` S. Gilles
@ 2014-10-31 15:07 ` Larry Finger
2014-11-01 3:41 ` S. Gilles
0 siblings, 1 reply; 7+ messages in thread
From: Larry Finger @ 2014-10-31 15:07 UTC (permalink / raw)
To: S. Gilles; +Cc: S. Gilles, Chaoming Li, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On 10/31/2014 08:56 AM, S. Gilles wrote:
>> 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8188CE 802.11b/g/n WiFi Adapter [10ec:8176] (rev 01)
>
> Any progress on this, or duplication? If this isn't replicable with
> the information in Bugzilla, I can provide anything requested.
Thanks for posting the PCI ID. I am currently on a family vacation, and I have
had little time for driver problems, and none for chasing missing information.
The attached patches should fix the kernel crashes; however, I doubt that the
driver will work. There seems to be a problem with DMA buffers that I have not
had time to find.
Larry
[-- Attachment #2: 0002-rtlwifi-rtl8192ce-rtl8192de-rtl8192se-Fix-handling-f.patch --]
[-- Type: text/x-patch, Size: 3484 bytes --]
>From bbaf5c9fc3bf1cf30576b546988e4e33cbd9c4a5 Mon Sep 17 00:00:00 2001
From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Sat, 25 Oct 2014 23:39:08 -0500
Subject: [PATCH 2/7] rtlwifi: rtl8192ce: rtl8192de: rtl8192se: Fix handling
for missing get_btc_status
To: linville@tuxdriver.com
Cc: netdev@vger.kernel.org,
troy_tan@realsil.com.cn
The recent changes in checking for Bluetooth status added some callbacks to code
in rtlwifi. To make certain that all callbacks are defined, a dummy routine has been
added to rtlwifi, and the drivers that need to use it are modified.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/core.c | 6 ++++++
drivers/net/wireless/rtlwifi/core.h | 1 +
drivers/net/wireless/rtlwifi/rtl8192ce/sw.c | 1 +
drivers/net/wireless/rtlwifi/rtl8192de/sw.c | 1 +
drivers/net/wireless/rtlwifi/rtl8192se/sw.c | 1 +
5 files changed, 10 insertions(+)
diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c
index f6179bc..07dae0d 100644
--- a/drivers/net/wireless/rtlwifi/core.c
+++ b/drivers/net/wireless/rtlwifi/core.c
@@ -1828,3 +1828,9 @@ const struct ieee80211_ops rtl_ops = {
.flush = rtl_op_flush,
};
EXPORT_SYMBOL_GPL(rtl_ops);
+
+bool rtl_btc_status_false(void)
+{
+ return false;
+}
+EXPORT_SYMBOL_GPL(rtl_btc_status_false);
diff --git a/drivers/net/wireless/rtlwifi/core.h b/drivers/net/wireless/rtlwifi/core.h
index 59cd3b9..624e1dc 100644
--- a/drivers/net/wireless/rtlwifi/core.h
+++ b/drivers/net/wireless/rtlwifi/core.h
@@ -42,5 +42,6 @@ void rtl_rfreg_delay(struct ieee80211_hw *hw, enum radio_path rfpath, u32 addr,
u32 mask, u32 data);
void rtl_bb_delay(struct ieee80211_hw *hw, u32 addr, u32 data);
bool rtl_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb);
+bool rtl_btc_status_false(void);
#endif
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c b/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
index d86b5b5..46ea076 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/sw.c
@@ -244,6 +244,7 @@ static struct rtl_hal_ops rtl8192ce_hal_ops = {
.phy_lc_calibrate = _rtl92ce_phy_lc_calibrate,
.phy_set_bw_mode_callback = rtl92ce_phy_set_bw_mode_callback,
.dm_dynamic_txpower = rtl92ce_dm_dynamic_txpower,
+ .get_btc_status = rtl_btc_status_false,
};
static struct rtl_mod_params rtl92ce_mod_params = {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/sw.c b/drivers/net/wireless/rtlwifi/rtl8192de/sw.c
index edab5a5..a0aba08 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/sw.c
@@ -251,6 +251,7 @@ static struct rtl_hal_ops rtl8192de_hal_ops = {
.get_rfreg = rtl92d_phy_query_rf_reg,
.set_rfreg = rtl92d_phy_set_rf_reg,
.linked_set_reg = rtl92d_linked_set_reg,
+ .get_btc_status = rtl_btc_status_false,
};
static struct rtl_mod_params rtl92de_mod_params = {
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/sw.c b/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
index 1bff2a0..5e16984 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192se/sw.c
@@ -294,6 +294,7 @@ static struct rtl_hal_ops rtl8192se_hal_ops = {
.set_bbreg = rtl92s_phy_set_bb_reg,
.get_rfreg = rtl92s_phy_query_rf_reg,
.set_rfreg = rtl92s_phy_set_rf_reg,
+ .get_btc_status = rtl_btc_status_false,
};
static struct rtl_mod_params rtl92se_mod_params = {
--
2.1.1
[-- Attachment #3: 0005-rtlwifi-rtl8192ce-Add-missing-section-to-read-descri.patch --]
[-- Type: text/x-patch, Size: 1813 bytes --]
>From 4f3d6a80198c539bbf200ff3a6dd00689b50bf78 Mon Sep 17 00:00:00 2001
From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Sat, 25 Oct 2014 23:51:15 -0500
Subject: [PATCH 5/7] rtlwifi: rtl8192ce: Add missing section to read
descriptor setting
To: linville@tuxdriver.com
Cc: netdev@vger.kernel.org,
troy_tan@realsil.com.cn
The new version of rtlwifi needs code in rtl92ce_get_desc() that returns
the buffer address for read operations.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
drivers/net/wireless/rtlwifi/rtl8192ce/def.h | 2 ++
drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/def.h b/drivers/net/wireless/rtlwifi/rtl8192ce/def.h
index 831df10..9b660df 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/def.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/def.h
@@ -114,6 +114,8 @@
LE_BITS_TO_4BYTE(((__pcmdfbhdr) + 4), 16, 4)
#define GET_C2H_CMD_FEEDBACK_CCX_SEQ(__pcmdfbhdr) \
LE_BITS_TO_4BYTE(((__pcmdfbhdr) + 4), 20, 12)
+#define GET_RX_STATUS_DESC_BUFF_ADDR(__pdesc) \
+ SHIFT_AND_MASK_LE(__pdesc + 24, 0, 32)
#define CHIP_VER_B BIT(4)
#define CHIP_BONDING_IDENTIFIER(_value) (((_value) >> 22) & 0x3)
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
index 2fb9c7a..dc3d20b 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192ce/trx.c
@@ -728,6 +728,9 @@ u32 rtl92ce_get_desc(u8 *p_desc, bool istx, u8 desc_name)
case HW_DESC_RXPKT_LEN:
ret = GET_RX_DESC_PKT_LEN(pdesc);
break;
+ case HW_DESC_RXBUFF_ADDR:
+ ret = GET_RX_STATUS_DESC_BUFF_ADDR(pdesc);
+ break;
default:
RT_ASSERT(false, "ERR rxdesc :%d not process\n",
desc_name);
--
2.1.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: PROBLEM: Boot failure with bad RIP value
2014-10-31 15:07 ` Larry Finger
@ 2014-11-01 3:41 ` S. Gilles
0 siblings, 0 replies; 7+ messages in thread
From: S. Gilles @ 2014-11-01 3:41 UTC (permalink / raw)
To: Larry Finger; +Cc: S. Gilles, Chaoming Li, linux-wireless
On Fri, Oct 31, 2014 at 10:07:59AM -0500, Larry Finger wrote:
> On 10/31/2014 08:56 AM, S. Gilles wrote:
> >> 03:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. RTL8188CE 802.11b/g/n WiFi Adapter [10ec:8176] (rev 01)
> >
> > Any progress on this, or duplication? If this isn't replicable with
> > the information in Bugzilla, I can provide anything requested.
>
> Thanks for posting the PCI ID. I am currently on a family vacation, and I have
> had little time for driver problems, and none for chasing missing information.
My apologies, I didn't realize you were still away.
> The attached patches should fix the kernel crashes; however, I doubt that the
> driver will work. There seems to be a problem with DMA buffers that I have not
> had time to find.
For the sake of followp, I can confirm on my machine: the boot is fine
but no /dev/wlan0. Thanks for the patches, I'll remain available to
test any more if needed.
--
S. Gilles
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-11-01 3:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13 23:45 PROBLEM: Boot failure with bad RIP value S. Gilles
2014-10-14 3:41 ` Larry Finger
2014-10-14 4:13 ` S. Gilles
2014-10-21 22:35 ` S. Gilles
2014-10-31 13:56 ` S. Gilles
2014-10-31 15:07 ` Larry Finger
2014-11-01 3:41 ` S. Gilles
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).