From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
ath6kl@lists.infradead.org
Subject: Re: Pull request: ath 20141024
Date: Mon, 27 Oct 2014 14:10:10 -0400 [thread overview]
Message-ID: <20141027181010.GG28300@tuxdriver.com> (raw)
In-Reply-To: <87bnp1ofof.fsf@kamboji.qca.qualcomm.com>
On Fri, Oct 24, 2014 at 02:44:32PM +0300, Kalle Valo wrote:
> Hi John,
>
> here are the latest ath10k patches plus a small logging change to ath6kl
> and wil6210. Unfortunately this time there's a small conflict in
> drivers/net/wireless/ath/wil6210/wil6210.h but luckily it's easy to fix.
> Here's an example how I propose to resolve it:
>
> ----------------------------------------------------------------------
> #define wil_to_ndev(i) (wil_to_wdev(i)->netdev)
> #define ndev_to_wil(n) (wdev_to_wil(n->ieee80211_ptr))
> #define wil_to_pcie_dev(i) (&i->pdev->dev)
>
> __printf(2, 3)
> void wil_dbg_trace(struct wil6210_priv *wil, const char *fmt, ...);
> __printf(2, 3)
> void wil_err(struct wil6210_priv *wil, const char *fmt, ...);
> __printf(2, 3)
> void wil_info(struct wil6210_priv *wil, const char *fmt, ...);
> #define wil_dbg(wil, fmt, arg...) do { \
> netdev_dbg(wil_to_ndev(wil), fmt, ##arg); \
> wil_dbg_trace(wil, fmt, ##arg); \
> } while (0)
>
> #define wil_dbg_irq(wil, fmt, arg...) wil_dbg(wil, "DBG[ IRQ]" fmt, ##arg)
> #define wil_dbg_txrx(wil, fmt, arg...) wil_dbg(wil, "DBG[TXRX]" fmt, ##arg)
> ----------------------------------------------------------------------
>
> I think a lesson learned here is that I should not apply patches which
> touch wil6210 and instead ask the submitter to split the patch. Sorry
> for this.
>
> Here's a changelog for the pull request:
>
> ----------------------------------------------------------------------
> Major changes are:
>
> o ethtool support (Ben)
>
> o print dev string prefix with debug hex buffers dump (Michal)
>
> o debugfs file to read calibration data from the firmware verification
> purposes (me)
>
> o fix fw_stats debugfs file, now results are more reliable (Michal)
>
> o firmware crash counters via debugfs (Ben&me)
>
> o various tracing points to debug firmware (Rajkumar)
>
> o make it possible to provide firmware calibration data via a file (me)
>
> And we have quite a lot of smaller fixes and clean up.
> ----------------------------------------------------------------------
>
> Please pull and let me know if you have any problems.
>
> Kalle
>
> ----------------------------------------------------------------------
>
> The following changes since commit b25f32cb02155d68c690255ba846796a1c248fd3:
>
> ath10k: use ether_addr_copy() (2014-09-18 10:47:03 +0300)
>
> are available in the git repository at:
>
> git://github.com/kvalo/ath.git tags/for-linville-20141024
>
> for you to fetch changes up to 84cbf3a7592879810f80cece6c7f736f099ab163:
>
> ath10k: split ce pipe init/alloc further (2014-10-23 16:41:32 +0300)
Pulling now...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2014-10-27 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 11:44 Pull request: ath 20141024 Kalle Valo
2014-10-27 18:10 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027181010.GG28300@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath10k@lists.infradead.org \
--cc=ath6kl@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).