From: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
"Michal Kazior" <michal.kazior@tieto.com>
Subject: Re: [PATCH] ath10k: add tracing for tx ieee80211 header
Date: Wed, 29 Oct 2014 11:16:05 +0530 [thread overview]
Message-ID: <20141029054604.GB20332@qca.qualcomm.com> (raw)
In-Reply-To: <1414515579.1834.4.camel@jlt4.sipsolutions.net>
On Tue, Oct 28, 2014 at 05:59:39PM +0100, Johannes Berg wrote:
> On Tue, 2014-10-28 at 22:18 +0530, Rajkumar Manoharan wrote:
> > For packet log, the transmitted frame 802.11 header alone is sufficient.
> > Recording entire packet is also consuming lot of disk space. To
> > optimize, add tracepoints for sending tx-ed 802.11 headers alone.
>
> FWIW, in iwlwifi I made the data portion (only!) a separate tracing
> subsystem, so that you can do
>
> trace-cmd record -e iwlwifi
>
> to get the hdrs, and
>
> trace-cmd record -e iwlwifi -e iwlwifi_data
>
> to get the hdrs, and the data, and then I put the two together in
> userspace. That way, "-e iwlwifi" gets most useful stuff, and adding -e
> iwlwifi_data when needed still has no duplication.
>
> With what you're suggesting, it will be difficult to control tracing to
> do exactly what's needed.
>
> Anyway, I don't really care, but this just caught my eye.
>
Thanks for your feedback. Will send updated patch.
-Rajkumar
prev parent reply other threads:[~2014-10-29 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 16:48 [PATCH] ath10k: add tracing for tx ieee80211 header Rajkumar Manoharan
2014-10-28 16:59 ` Johannes Berg
2014-10-29 5:46 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029054604.GB20332@qca.qualcomm.com \
--to=rmanohar@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).