linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH 0/3] debugfs: adding helper for single seq_file
Date: Thu, 30 Oct 2014 15:19:22 -0400	[thread overview]
Message-ID: <20141030191922.GA3768@tuxdriver.com> (raw)
In-Reply-To: <1414498752-9746-1-git-send-email-arend@broadcom.com>

On Tue, Oct 28, 2014 at 01:19:09PM +0100, Arend van Spriel wrote:
> The first patch was already posted earlier:
> 
> Message-ID: <1413043315-22332-1-git-send-email-arend@broadcom.com>
> 
> This series include changes in driver code to investigate potential
> code savings. As example used the ath9k driver as it has a fair
> amount of debugfs files. In this series it changes 7 debugfs entries
> to use seq_file and the helper function. Below the output of the
> size utility:
> 
>    text	   data	    bss	    dec	    hex	filename
>  115968	   1225	     28	 117221	  1c9e5	original/ath9k.o
>  113224	   1225	     28	 114477	  1bf2d	seq_file/ath9k.o
>  111024	   1225	     28	 112277	  1b695	helper/ath9k.o
> 
> This series is for 3.19 kernel and applies to the driver-core-next
> branch of the driver-core repository. If needed the ath9k patches
> may be dropped for now and I will resubmit them to wireless-next
> once the debugfs patch has made it into linux-next.
> 
> Arend van Spriel (3):
>   debugfs: add helper function to create device related seq_file
>   ath: use seq_file api for ath9k debugfs files
>   ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file
>     entries

Greg,

If you are happy with the debugfs change then feel free to merge the
wireless patches along with it.

John

> 
>  drivers/net/wireless/ath/ath9k/ahb.c   |   1 +
>  drivers/net/wireless/ath/ath9k/debug.c | 429 +++++++++++----------------------
>  drivers/net/wireless/ath/ath9k/debug.h |   3 +-
>  drivers/net/wireless/ath/ath9k/pci.c   |   1 +
>  fs/debugfs/file.c                      |  54 +++++
>  include/linux/debugfs.h                |  16 +-
>  6 files changed, 207 insertions(+), 297 deletions(-)
> 
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  parent reply	other threads:[~2014-10-30 19:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 12:19 [PATCH 0/3] debugfs: adding helper for single seq_file Arend van Spriel
2014-10-28 12:19 ` [PATCH 1/3] debugfs: add helper function to create device related seq_file Arend van Spriel
2014-11-07 19:04   ` Greg Kroah-Hartman
2014-10-28 12:19 ` [PATCH 2/3] ath: use seq_file api for ath9k debugfs files Arend van Spriel
2014-10-31 20:07   ` John W. Linville
2014-11-07 19:05   ` Greg Kroah-Hartman
2014-11-08 13:44     ` Arend van Spriel
2014-11-08 14:07       ` Arend van Spriel
2014-11-08 16:25         ` Greg Kroah-Hartman
2014-10-28 12:19 ` [PATCH 3/3] ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries Arend van Spriel
2014-10-31 20:07   ` John W. Linville
2014-11-07 19:05   ` Greg Kroah-Hartman
2014-10-30 19:19 ` John W. Linville [this message]
2014-10-30 19:39   ` [PATCH 0/3] debugfs: adding helper for single seq_file Greg Kroah-Hartman
2014-10-30 19:48     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030191922.GA3768@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=arend@broadcom.com \
    --cc=ath9k-devel@venema.h4ckr.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).