From: James Cameron <quozl@laptop.org>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
cluo@marvell.com, huxm@marvell.com, yangyang@marvell.com,
Avinash Patil <patila@marvell.com>
Subject: Re: [Patch v2 3/5] mwifiex: fix out of memory issue observed for USB chipsets
Date: Wed, 5 Nov 2014 17:25:16 +1100 [thread overview]
Message-ID: <20141105062516.GS1015@us.netrek.org> (raw)
In-Reply-To: <1415187271-17914-3-git-send-email-akarwar@marvell.com>
On Wed, Nov 05, 2014 at 05:04:29PM +0530, Amitkumar Karwar wrote:
> On some platforms, system goes out of memory during heavy
> Rx traffic with our USB chipsets.
>
> In case of SDIO/PCIe, after receiving 50 packets in Rx queue
> we stop processing interrupts till packets pending fall below
> low threshold i.e 20. We don't have similar logic for USB,
> so if host platform is slow, we would hit a case where firmware
> keeps on pushing packets at high speed than driver/kernel can
> process.
>
> We will stop submitting URBs for Rx data when pending packet
> count reaches high threshold and restart them when enough
> packets are consumed to solve the problem.
Other drivers and user activity can deplete memory. How does this
patch solve the problem when dev_alloc_skb fails? I'm worried the
underlying issue remains; handling out of memory.
--
James Cameron
http://quozl.linux.org.au/
next prev parent reply other threads:[~2014-11-05 6:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 11:34 [Patch v2 1/5] mwifiex: rx workqueue support for USB interface Amitkumar Karwar
2014-11-05 11:34 ` [Patch v2 2/5] mwifiex: remove data_complete handler Amitkumar Karwar
2014-11-05 11:34 ` [Patch v2 3/5] mwifiex: fix out of memory issue observed for USB chipsets Amitkumar Karwar
2014-11-05 6:25 ` James Cameron [this message]
2014-11-05 6:53 ` Amitkumar Karwar
2014-11-05 11:34 ` [Patch v2 4/5] mwifiex: do not setup AMPDU/AMSDU with broadcast receiver Amitkumar Karwar
2014-11-05 11:34 ` [Patch v2 5/5] mwifiex: fix warning while starting BSS Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105062516.GS1015@us.netrek.org \
--to=quozl@laptop.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=patila@marvell.com \
--cc=yangyang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).