From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3 3.18] rtlwifi: rtl8192se: Fix connection problems
Date: Fri, 7 Nov 2014 10:19:08 -0500 [thread overview]
Message-ID: <20141107151908.GB29733@tuxdriver.com> (raw)
In-Reply-To: <545BFA52.6000309@lwfinger.net>
On Thu, Nov 06, 2014 at 04:46:42PM -0600, Larry Finger wrote:
> On 11/06/2014 02:45 PM, John W. Linville wrote:
> >On Wed, Nov 05, 2014 at 07:10:54PM -0600, Larry Finger wrote:
> >>Changes in the vendor driver were added to rtlwifi, but some updates
> >>to rtl8192se were missed.
> >>
> >>Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> >>---
> >> drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 129 +++++++++++++--------------
> >> drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 8 +-
> >> drivers/net/wireless/rtlwifi/rtl8192se/sw.c | 4 +
> >> drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 23 +++++
> >> drivers/net/wireless/rtlwifi/rtl8192se/trx.h | 4 +
> >> 5 files changed, 100 insertions(+), 68 deletions(-)
> >
> >This looks a bit big for a fix. Could this be broken-up a bit more?
> >Perhaps you could enhance the changelog a bit more?
>
> I had used a scatter-gun approach to finding the missing parts, and I did
> not take the time to see which changes were crucial, and which were not.
>
> Now that I knew what it took, I was able to eliminate a lot of the patch
> that can be deferred for 3.19.
>
> The commit message and the changelog for the new version are
>
> Changes in the vendor driver were added to rtlwifi, but some updates
> to rtl8192se were missed, and the driver could neither scan nor connect.
> There are other changes that will enhance performance, but this minimal
> set fixes the basic functionality.
>
> drivers/net/wireless/rtlwifi/pci.c | 3 ++-
> drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 7 +++++--
> drivers/net/wireless/rtlwifi/rtl8192se/phy.c | 2 ++
> drivers/net/wireless/rtlwifi/rtl8192se/sw.c | 16 ++++++++++++++++
> 4 files changed, 25 insertions(+), 3 deletions(-)
>
> Will that be OK? I need to do more testing, but V2 of the patch should be
> ready for submission by tomorrow.
That sounds better, at least. :-) Thanks, Larry!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2014-11-07 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 1:10 [PATCH 0/3i 3.18] Fix more problems with rtlwifi Larry Finger
2014-11-06 1:10 ` [PATCH 1/3 3.18] rtlwifi: Fix setting of tx descriptor for new trx flow Larry Finger
2014-11-06 1:10 ` [PATCH 2/3 3.18] rtlwifi: Fix errors in descriptor manipulation Larry Finger
2014-11-06 1:10 ` [PATCH 3/3 3.18] rtlwifi: rtl8192se: Fix connection problems Larry Finger
2014-11-06 20:45 ` John W. Linville
2014-11-06 22:46 ` Larry Finger
2014-11-07 15:19 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107151908.GB29733@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).