* [PATCH] mac80211: skip legacy rate mask handling for VHT rates
@ 2014-11-15 2:48 Felix Fietkau
2014-11-15 11:05 ` Karl Beldan
2014-11-19 17:38 ` Johannes Berg
0 siblings, 2 replies; 4+ messages in thread
From: Felix Fietkau @ 2014-11-15 2:48 UTC (permalink / raw)
To: linux-wireless; +Cc: johannes, karl.beldan
The rate mask code currently assumes that a rate is legacy if
IEEE80211_TX_RC_MCS is not set. This might be the cause of bogus VHT
rates being reported with minstrel_ht.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
net/mac80211/rate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
index 6081329..f6fea67f 100644
--- a/net/mac80211/rate.c
+++ b/net/mac80211/rate.c
@@ -385,7 +385,7 @@ static void rate_idx_match_mask(struct ieee80211_tx_rate *rate,
*rate = alt_rate;
return;
}
- } else {
+ } else if (!(rate->flags & IEEE80211_TX_RC_VHT_MCS)) {
/* handle legacy rates */
if (rate_idx_match_legacy_mask(rate, sband->n_bitrates, mask))
return;
--
2.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mac80211: skip legacy rate mask handling for VHT rates
2014-11-15 2:48 [PATCH] mac80211: skip legacy rate mask handling for VHT rates Felix Fietkau
@ 2014-11-15 11:05 ` Karl Beldan
2014-11-15 11:44 ` Jouni Malinen
2014-11-19 17:38 ` Johannes Berg
1 sibling, 1 reply; 4+ messages in thread
From: Karl Beldan @ 2014-11-15 11:05 UTC (permalink / raw)
To: Jouni Malinen, Felix Fietkau; +Cc: linux-wireless, johannes
On Sat, Nov 15, 2014 at 03:48:54AM +0100, Felix Fietkau wrote:
> The rate mask code currently assumes that a rate is legacy if
> IEEE80211_TX_RC_MCS is not set. This might be the cause of bogus VHT
> rates being reported with minstrel_ht.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> ---
> net/mac80211/rate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
> index 6081329..f6fea67f 100644
> --- a/net/mac80211/rate.c
> +++ b/net/mac80211/rate.c
> @@ -385,7 +385,7 @@ static void rate_idx_match_mask(struct ieee80211_tx_rate *rate,
> *rate = alt_rate;
> return;
> }
> - } else {
> + } else if (!(rate->flags & IEEE80211_TX_RC_VHT_MCS)) {
> /* handle legacy rates */
> if (rate_idx_match_legacy_mask(rate, sband->n_bitrates, mask))
> return;
Does it fix things on your side Jouni ?
Karl
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mac80211: skip legacy rate mask handling for VHT rates
2014-11-15 11:05 ` Karl Beldan
@ 2014-11-15 11:44 ` Jouni Malinen
0 siblings, 0 replies; 4+ messages in thread
From: Jouni Malinen @ 2014-11-15 11:44 UTC (permalink / raw)
To: Karl Beldan; +Cc: Felix Fietkau, linux-wireless, johannes
On Sat, Nov 15, 2014 at 12:05:00PM +0100, Karl Beldan wrote:
> On Sat, Nov 15, 2014 at 03:48:54AM +0100, Felix Fietkau wrote:
> > The rate mask code currently assumes that a rate is legacy if
> > IEEE80211_TX_RC_MCS is not set. This might be the cause of bogus VHT
> > rates being reported with minstrel_ht.
> > - } else {
> > + } else if (!(rate->flags & IEEE80211_TX_RC_VHT_MCS)) {
> Does it fix things on your side Jouni ?
Yes, it does resolve the nfc_p2p_* test case failures with
CONFIG_MAC80211_RC_MINSTREL_VHT=y.
--
Jouni Malinen PGP id EFC895FA
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mac80211: skip legacy rate mask handling for VHT rates
2014-11-15 2:48 [PATCH] mac80211: skip legacy rate mask handling for VHT rates Felix Fietkau
2014-11-15 11:05 ` Karl Beldan
@ 2014-11-19 17:38 ` Johannes Berg
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2014-11-19 17:38 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, karl.beldan
On Sat, 2014-11-15 at 03:48 +0100, Felix Fietkau wrote:
> The rate mask code currently assumes that a rate is legacy if
> IEEE80211_TX_RC_MCS is not set. This might be the cause of bogus VHT
> rates being reported with minstrel_ht.
Applied.
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-19 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-15 2:48 [PATCH] mac80211: skip legacy rate mask handling for VHT rates Felix Fietkau
2014-11-15 11:05 ` Karl Beldan
2014-11-15 11:44 ` Jouni Malinen
2014-11-19 17:38 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).