From: "John W. Linville" <linville@tuxdriver.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs
Date: Tue, 25 Nov 2014 14:20:25 -0500 [thread overview]
Message-ID: <20141125192025.GI15476@tuxdriver.com> (raw)
In-Reply-To: <5474D581.5010909@broadcom.com>
On Tue, Nov 25, 2014 at 08:16:17PM +0100, Arend van Spriel wrote:
> On 11/25/14 20:05, John W. Linville wrote:
> >On Tue, Nov 25, 2014 at 01:49:45PM -0500, John W. Linville wrote:
> >>On Tue, Nov 25, 2014 at 01:12:34PM +0100, Arend van Spriel wrote:
> >>>On 11/24/14 22:50, John W. Linville wrote:
> >>>>Hmmm...I'm not sure why, but this is causing problems for me...
> >>>>
> >>>>ERROR: "brcmu_boardrev_str" [drivers/net/wireless/brcm80211/brcmsmac/brcmsmac.ko] undefined!
> >>>
> >>>I am confused as well. I did not have such an issue. The function is
> >>>provided by brcmutil.ko (patch 2/4) and I did an EXPORT_SYMBOL and added it
> >>>to the include file. Missing something? Also I don't see this issue over
> >>>here. I will do a clean build on the wireless-next tree and see if I can
> >>>reproduce this.
> >>
> >>I did a clean build after applying the patches in question, and I
> >>still got the same issue at link time. I'll attach my .config for
> >>you to try.
> >
> >I think that was too big...trying the compressed version...
>
> I received both. I assume he commit mentioned below is without the patches.
>
> Regards,
> Arend
>
> >>FWIW, I am building wireless-testing at commit
> >>733ea24c8c98d99c747b89710e520ac6e9f3951b.
> >
> >John
That commit includes all 4 patches. I reverted the last three later
in the wireless-testing history.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-11-25 19:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 21:26 [PATCH 0/4] brcm80211: minor rework Arend van Spriel
2014-11-20 21:26 ` [PATCH 1/4] brcmfmac: fix static checker warning in pmklist handling Arend van Spriel
2014-11-20 21:27 ` [PATCH 2/4] brcmutil: add helper function to format board revision Arend van Spriel
2014-11-24 21:53 ` John W. Linville
2014-11-25 10:01 ` Arend van Spriel
2014-11-25 18:51 ` John W. Linville
2014-11-20 21:27 ` [PATCH 3/4] brcmsmac: extend hardware info shown in debugfs Arend van Spriel
2014-11-24 21:50 ` John W. Linville
2014-11-25 12:12 ` Arend van Spriel
2014-11-25 13:00 ` Arend van Spriel
2014-11-25 18:50 ` John W. Linville
2014-11-25 18:49 ` John W. Linville
2014-11-25 19:05 ` John W. Linville
2014-11-25 19:16 ` Arend van Spriel
2014-11-25 19:20 ` John W. Linville [this message]
2014-11-25 19:49 ` Arend van Spriel
2014-11-25 19:23 ` Arend van Spriel
2014-11-25 19:28 ` Arend van Spriel
2014-11-20 21:27 ` [PATCH 4/4] brcmfmac: correct .disconnect() callback while connecting Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125192025.GI15476@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).